Skip to content

Commit 063e9d3

Browse files
author
Stefan Bossbaly
committed
fixup! [HWASan] Fix symbol indexing
1 parent a61dedb commit 063e9d3

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

compiler-rt/lib/hwasan/scripts/hwasan_symbolize

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def handle_shstrtab(mv, e_shoff):
7171
_, shstrndx_sh_offset, shstrndx_sh_size = handle_Shdr(shstrndx_sh)
7272
return mv[shstrndx_sh_offset:shstrndx_sh_offset + shstrndx_sh_size]
7373

74-
def shstrtab_sh_name(mv):
74+
def read_string(mv):
7575
name = ""
7676
for byte in mv:
7777
char = chr(byte)
@@ -101,14 +101,14 @@ def handle_elf(mv):
101101
e_shnum, = struct.unpack_from('<H', buffer=mv, offset=e_shnum_offset)
102102
e_shoff, = struct.unpack_from('<Q', buffer=mv, offset=e_shoff_offset)
103103

104-
# Section where all the section header names are stored
104+
# Section where all the section header names are stored.
105105
shstr = handle_shstrtab(mv, e_shoff)
106106

107107
for i in range(0, e_shnum):
108108
start = e_shoff + i * Shdr_size
109109
sh = mv[start: start + Shdr_size]
110110
sh_name_offset, sh_offset, sh_size = handle_Shdr(sh)
111-
sh_name = shstrtab_sh_name(shstr[sh_name_offset:])
111+
sh_name = read_string(shstr[sh_name_offset:])
112112
sh_type = unpack_sh_type(sh)
113113

114114
if sh_name == ".debug_info":
@@ -315,7 +315,6 @@ class Symbolizer:
315315
if bid is not None:
316316
if bid in self.__index:
317317
print("Duplicate build ID {} for {} and {}".format(bid, self.__index[bid], filename), file=sys.stderr)
318-
sys.exit(1)
319318
self.__index[bid] = filename
320319

321320
def symbolize_line(self, line):

0 commit comments

Comments
 (0)