Skip to content

Commit 0650fee

Browse files
committed
[HLSL] Fix resource kind for RasterizerOrderedStructuredBuffer
This is a kind of StructuredBuffer, so it should be "Raw" and not "Typed".
1 parent e0b522d commit 0650fee

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

clang/lib/Sema/HLSLExternalSemaSource.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ void HLSLExternalSemaSource::defineHLSLTypesWithForwardDeclarations() {
548548
.Record;
549549
onCompletion(Decl, [this](CXXRecordDecl *Decl) {
550550
setupBufferType(Decl, *SemaPtr, ResourceClass::UAV,
551-
ResourceKind::TypedBuffer, /*IsROV=*/true,
551+
ResourceKind::RawBuffer, /*IsROV=*/true,
552552
/*RawBuffer=*/true)
553553
.addArraySubscriptOperators()
554554
.completeDefinition();

clang/test/AST/HLSL/RasterizerOrderedStructuredBuffer-AST.hlsl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ RasterizerOrderedStructuredBuffer<int> Buffer;
3535
// CHECK-SAME{LITERAL}: [[hlsl::is_rov]]
3636
// CHECK-SAME{LITERAL}: [[hlsl::raw_buffer]]
3737
// CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]]
38-
// CHECK-NEXT: HLSLResourceAttr 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> Implicit TypedBuffer
38+
// CHECK-NEXT: HLSLResourceAttr 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> Implicit RawBuffer
3939

4040
// CHECK: CXXMethodDecl 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> <invalid sloc> operator[] 'element_type &const (unsigned int) const'
4141
// CHECK-NEXT: ParmVarDecl 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> <invalid sloc> Idx 'unsigned int'
@@ -63,4 +63,4 @@ RasterizerOrderedStructuredBuffer<int> Buffer;
6363
// CHECK-SAME{LITERAL}: [[hlsl::is_rov]]
6464
// CHECK-SAME{LITERAL}: [[hlsl::raw_buffer]]
6565
// CHECK-SAME{LITERAL}: [[hlsl::contained_type(int)]]
66-
// CHECK-NEXT: HLSLResourceAttr 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> Implicit TypedBuffer
66+
// CHECK-NEXT: HLSLResourceAttr 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> Implicit RawBuffer

0 commit comments

Comments
 (0)