Skip to content

Commit 0676c4f

Browse files
committed
remove newlines between different include types.
Add brief descriptions of each header file's purpose as per llvm/docs/CodingStandards.rst
1 parent aa546bc commit 0676c4f

File tree

9 files changed

+22
-11
lines changed

9 files changed

+22
-11
lines changed

lldb/tools/yaml2macho-core/CoreSpec.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,8 @@
77
//===----------------------------------------------------------------------===//
88

99
#include "CoreSpec.h"
10-
1110
#include "llvm/BinaryFormat/MachO.h"
1211
#include "llvm/Support/YAMLTraits.h"
13-
1412
#include <stdio.h>
1513
#include <string>
1614

lldb/tools/yaml2macho-core/CoreSpec.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,13 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8+
///
9+
/// \file
10+
/// CoreSpec holds the internal representation of the data that will be
11+
/// written into the corefile. Theads, register sets within threads, registers
12+
/// within register sets. Block of memory. Metadata about the CPU or binaries
13+
/// that were present.
14+
//===----------------------------------------------------------------------===//
815

916
#ifndef YAML2MACHOCOREFILE_CORESPEC_H
1017
#define YAML2MACHOCOREFILE_CORESPEC_H

lldb/tools/yaml2macho-core/LCNoteWriter.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,14 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
#include "lldb/Utility/UUID.h"
98

109
#include "LCNoteWriter.h"
1110
#include "Utility.h"
12-
11+
#include "lldb/Utility/UUID.h"
12+
#include "llvm/BinaryFormat/MachO.h"
1313
#include <ctype.h>
1414
#include <stdlib.h>
1515

16-
#include "llvm/BinaryFormat/MachO.h"
17-
1816
void create_lc_note_binary_load_cmd(const CoreSpec &spec,
1917
std::vector<uint8_t> &cmds,
2018
const Binary &binary,

lldb/tools/yaml2macho-core/LCNoteWriter.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8+
/// \file
9+
/// Functions to add an LC_NOTE load command to the corefile's load commands,
10+
/// and supply the payload of that LC_NOTE separately.
11+
//===----------------------------------------------------------------------===//
812

913
#ifndef YAML2MACHOCOREFILE_LCNOTEWRITER_H
1014
#define YAML2MACHOCOREFILE_LCNOTEWRITER_H

lldb/tools/yaml2macho-core/MemoryWriter.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include "MemoryWriter.h"
1010
#include "CoreSpec.h"
1111
#include "Utility.h"
12-
1312
#include "llvm/BinaryFormat/MachO.h"
1413

1514
void create_lc_segment_cmd(const CoreSpec &spec, std::vector<uint8_t> &cmds,

lldb/tools/yaml2macho-core/MemoryWriter.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8+
/// \file
9+
/// Functions to emit the LC_SEGMENT load command, and to provide the bytes
10+
/// that appear later in the corefile.
11+
//===----------------------------------------------------------------------===//
812

913
#ifndef YAML2MACHOCOREFILE_MEMORYWRITER_H
1014
#define YAML2MACHOCOREFILE_MEMORYWRITER_H

lldb/tools/yaml2macho-core/ThreadWriter.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@
99
#include "ThreadWriter.h"
1010
#include "CoreSpec.h"
1111
#include "Utility.h"
12-
1312
#include "llvm/BinaryFormat/MachO.h"
14-
1513
#include <algorithm>
1614
#include <stdio.h>
1715

lldb/tools/yaml2macho-core/ThreadWriter.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8+
/// \file
9+
/// Functions to emit LC_THREAD bytes to the corefile's Mach-O load commands,
10+
/// specifying the threads, the register sets ("flavors") within those threads,
11+
/// and all of the registers within those register sets.
12+
//===----------------------------------------------------------------------===//
813

914
#ifndef YAML2MACHOCOREFILE_THREADWRITER_H
1015
#define YAML2MACHOCOREFILE_THREADWRITER_H

lldb/tools/yaml2macho-core/yaml2macho.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
#include "MemoryWriter.h"
1212
#include "ThreadWriter.h"
1313
#include "Utility.h"
14-
1514
#include "llvm/BinaryFormat/MachO.h"
16-
1715
#include <getopt.h>
1816
#include <stdio.h>
1917
#include <string>

0 commit comments

Comments
 (0)