Skip to content

Commit 06fb3ad

Browse files
arsenmarsenm
committed
clang/AMDGPU: Emit atomicrmw for flat/global atomic min/max f64 builtins
1 parent a15cfba commit 06fb3ad

File tree

2 files changed

+21
-33
lines changed

2 files changed

+21
-33
lines changed

‎clang/lib/CodeGen/CGBuiltin.cpp‎

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -18791,32 +18791,6 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID,
1879118791
Function *F = CGM.getIntrinsic(Intrin, { Src0->getType() });
1879218792
return Builder.CreateCall(F, { Src0, Builder.getFalse() });
1879318793
}
18794-
case AMDGPU::BI__builtin_amdgcn_global_atomic_fmin_f64:
18795-
case AMDGPU::BI__builtin_amdgcn_global_atomic_fmax_f64:
18796-
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmin_f64:
18797-
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: {
18798-
Intrinsic::ID IID;
18799-
llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext());
18800-
switch (BuiltinID) {
18801-
case AMDGPU::BI__builtin_amdgcn_global_atomic_fmin_f64:
18802-
IID = Intrinsic::amdgcn_global_atomic_fmin;
18803-
break;
18804-
case AMDGPU::BI__builtin_amdgcn_global_atomic_fmax_f64:
18805-
IID = Intrinsic::amdgcn_global_atomic_fmax;
18806-
break;
18807-
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmin_f64:
18808-
IID = Intrinsic::amdgcn_flat_atomic_fmin;
18809-
break;
18810-
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64:
18811-
IID = Intrinsic::amdgcn_flat_atomic_fmax;
18812-
break;
18813-
}
18814-
llvm::Value *Addr = EmitScalarExpr(E->getArg(0));
18815-
llvm::Value *Val = EmitScalarExpr(E->getArg(1));
18816-
llvm::Function *F =
18817-
CGM.getIntrinsic(IID, {ArgTy, Addr->getType(), Val->getType()});
18818-
return Builder.CreateCall(F, {Addr, Val});
18819-
}
1882018794
case AMDGPU::BI__builtin_amdgcn_global_load_tr_b64_i32:
1882118795
case AMDGPU::BI__builtin_amdgcn_global_load_tr_b64_v2i32:
1882218796
case AMDGPU::BI__builtin_amdgcn_global_load_tr_b128_v4i16:
@@ -19200,7 +19174,11 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID,
1920019174
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fadd_f32:
1920119175
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fadd_f64:
1920219176
case AMDGPU::BI__builtin_amdgcn_global_atomic_fadd_v2bf16:
19203-
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fadd_v2bf16: {
19177+
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fadd_v2bf16:
19178+
case AMDGPU::BI__builtin_amdgcn_global_atomic_fmin_f64:
19179+
case AMDGPU::BI__builtin_amdgcn_global_atomic_fmax_f64:
19180+
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmin_f64:
19181+
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: {
1920419182
llvm::AtomicRMWInst::BinOp BinOp;
1920519183
switch (BuiltinID) {
1920619184
case AMDGPU::BI__builtin_amdgcn_atomic_inc32:
@@ -19227,8 +19205,12 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID,
1922719205
BinOp = llvm::AtomicRMWInst::FAdd;
1922819206
break;
1922919207
case AMDGPU::BI__builtin_amdgcn_ds_fminf:
19208+
case AMDGPU::BI__builtin_amdgcn_global_atomic_fmin_f64:
19209+
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmin_f64:
1923019210
BinOp = llvm::AtomicRMWInst::FMin;
1923119211
break;
19212+
case AMDGPU::BI__builtin_amdgcn_global_atomic_fmax_f64:
19213+
case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64:
1923219214
case AMDGPU::BI__builtin_amdgcn_ds_fmaxf:
1923319215
BinOp = llvm::AtomicRMWInst::FMax;
1923419216
break;

‎clang/test/CodeGenOpenCL/builtins-fp-atomics-gfx90a.cl‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ void test_global_add_half2(__global half2 *addr, half2 x) {
2727
}
2828

2929
// CHECK-LABEL: test_global_global_min_f64
30-
// CHECK: call double @llvm.amdgcn.global.atomic.fmin.f64.p1.f64(ptr addrspace(1) %{{.*}}, double %{{.*}})
30+
// CHECK: = atomicrmw fmin ptr addrspace(1) {{.+}}, double %{{.+}} syncscope("agent") monotonic, align 8, !amdgpu.no.fine.grained.memory !{{[0-9]+$}}
31+
3132
// GFX90A-LABEL: test_global_global_min_f64$local
3233
// GFX90A: global_atomic_min_f64
3334
void test_global_global_min_f64(__global double *addr, double x){
@@ -36,7 +37,8 @@ void test_global_global_min_f64(__global double *addr, double x){
3637
}
3738

3839
// CHECK-LABEL: test_global_max_f64
39-
// CHECK: call double @llvm.amdgcn.global.atomic.fmax.f64.p1.f64(ptr addrspace(1) %{{.*}}, double %{{.*}})
40+
// CHECK: = atomicrmw fmax ptr addrspace(1) {{.+}}, double %{{.+}} syncscope("agent") monotonic, align 8, !amdgpu.no.fine.grained.memory !{{[0-9]+$}}
41+
4042
// GFX90A-LABEL: test_global_max_f64$local
4143
// GFX90A: global_atomic_max_f64
4244
void test_global_max_f64(__global double *addr, double x){
@@ -65,7 +67,8 @@ void test_flat_global_add_f64(__global double *addr, double x){
6567
}
6668

6769
// CHECK-LABEL: test_flat_min_flat_f64
68-
// CHECK: call double @llvm.amdgcn.flat.atomic.fmin.f64.p0.f64(ptr %{{.*}}, double %{{.*}})
70+
// CHECK: = atomicrmw fmin ptr {{.+}}, double %{{.+}} syncscope("agent") monotonic, align 8, !amdgpu.no.fine.grained.memory !{{[0-9]+$}}
71+
6972
// GFX90A-LABEL: test_flat_min_flat_f64$local
7073
// GFX90A: flat_atomic_min_f64
7174
void test_flat_min_flat_f64(__generic double *addr, double x){
@@ -74,7 +77,8 @@ void test_flat_min_flat_f64(__generic double *addr, double x){
7477
}
7578

7679
// CHECK-LABEL: test_flat_global_min_f64
77-
// CHECK: call double @llvm.amdgcn.flat.atomic.fmin.f64.p1.f64(ptr addrspace(1) %{{.*}}, double %{{.*}})
80+
// CHECK: = atomicrmw fmin ptr addrspace(1) {{.+}}, double %{{.+}} syncscope("agent") monotonic, align 8, !amdgpu.no.fine.grained.memory !{{[0-9]+$}}
81+
7882
// GFX90A: test_flat_global_min_f64$local
7983
// GFX90A: global_atomic_min_f64
8084
void test_flat_global_min_f64(__global double *addr, double x){
@@ -83,7 +87,8 @@ void test_flat_global_min_f64(__global double *addr, double x){
8387
}
8488

8589
// CHECK-LABEL: test_flat_max_flat_f64
86-
// CHECK: call double @llvm.amdgcn.flat.atomic.fmax.f64.p0.f64(ptr %{{.*}}, double %{{.*}})
90+
// CHECK: = atomicrmw fmax ptr {{.+}}, double %{{.+}} syncscope("agent") monotonic, align 8, !amdgpu.no.fine.grained.memory !{{[0-9]+$}}
91+
8792
// GFX90A-LABEL: test_flat_max_flat_f64$local
8893
// GFX90A: flat_atomic_max_f64
8994
void test_flat_max_flat_f64(__generic double *addr, double x){
@@ -92,7 +97,8 @@ void test_flat_max_flat_f64(__generic double *addr, double x){
9297
}
9398

9499
// CHECK-LABEL: test_flat_global_max_f64
95-
// CHECK: call double @llvm.amdgcn.flat.atomic.fmax.f64.p1.f64(ptr addrspace(1) %{{.*}}, double %{{.*}})
100+
// CHECK: = atomicrmw fmax ptr addrspace(1) {{.+}}, double %{{.+}} syncscope("agent") monotonic, align 8, !amdgpu.no.fine.grained.memory !{{[0-9]+$}}
101+
96102
// GFX90A-LABEL: test_flat_global_max_f64$local
97103
// GFX90A: global_atomic_max_f64
98104
void test_flat_global_max_f64(__global double *addr, double x){

0 commit comments

Comments
 (0)