@@ -264,13 +264,13 @@ Your options are as follows:
264264
265265 This approach allows GitHub to display clean, incremental diffs for each PR
266266 in the stack, making it much easier for reviewers to see what has changed at
267- each step. Once `feature_1 ` is merged, GitHub would automatically rebase and
267+ each step. Once `feature_1 ` is merged, GitHub will automatically rebase and
268268 re-target your branch `feature_2 ` to `main `. For more complex stacks, you can
269269 perform this step using the web interface.
270270
271271 This approach requires
272- `Commit Access <https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access >`_
273- . However, if you are involved with a Stacked PR, there's a good chance you'll
272+ `Commit Access <https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access >`_.
273+ However, if you are involved with a Stacked PR, there's a good chance you'll
274274 be granted access.
275275
276276#. Two PRs with a dependency note
@@ -279,7 +279,6 @@ Your options are as follows:
279279 note in the PR summary indicating that it depends on PR_1 (e.g.,
280280 “Depends on #PR_1”).
281281
282- The disadvantage of this approach is that GitHub will not show a clean diff.
283282 To make review easier, make it clear which commits are part of the base PR
284283 and which are new, e.g. "The first N commits are from the base PR". This
285284 helps reviewers focus only on the incremental changes.
0 commit comments