Correct typos and misc nits

Author: mysterymath

clang/docs/ReleaseNotes.rst

@@ -341,10 +341,11 @@ Attribute Changes in Clang
 - New format attributes ``gnu_printf``, ``gnu_scanf``, ``gnu_strftime`` and ``gnu_strfmon`` are added
   as aliases for ``printf``, ``scanf``, ``strftime`` and ``strfmon``. (#GH16219)
 
-- New attribute ``modular_format`` to allow dynamically selecting at link time
-  which aspects of a statically linked libc's printf (et al) implementation are
-  required. This can reduce code size without requiring e.g. multilibs for
-  printf features. Requires cooperation with the libc implementation.
+- Added new attribute ``modular_format`` to allow dynamically selecting at link
+  time which aspects of a statically linked libc's printf (et al)
+  implementation are required. This can reduce code size without requiring e.g.
+  multilibs for printf features. Requires cooperation with the libc
+  implementation.
 
 Improvements to Clang's diagnostics
 -----------------------------------

clang/include/clang/Basic/AttrDocs.td

@@ -9680,15 +9680,15 @@ def ModularFormatDocs : Documentation {
   let Content = [{
 The ``modular_format`` attribute can be applied to a function that bears the
 ``format`` attribute (or standard library functions) to indicate that the
-implementation is "modular", that is, that the implemenation is logically
+implementation is "modular", that is, that the implementation is logically
 divided into a number of named aspects. When the compiler can determine that
 not all aspects of the implementation are needed for a given call, the compiler
 may redirect the call to the identifier given as the first argument to the
 attribute (the modular implementation function).
 
 The second argument is a implementation name, and the remaining arguments are
 aspects of the format string for the compiler to report. The implementation
-name is an unevaluted identifier be in the C namespace.
+name is an unevaluated identifier be in the C namespace.
 
 The compiler reports that a call requires an aspect by issuing a relocation for
 the symbol ``<impl_name>_<aspect>`` at the point of the call. This arranges for

clang/lib/CodeGen/CGCall.cpp

@@ -2560,7 +2560,6 @@ void CodeGenModule::ConstructAttributeList(StringRef Name,
       FuncAttrs.addAttribute("aarch64_pstate_sm_body");
 
     if (auto *ModularFormat = TargetDecl->getAttr<ModularFormatAttr>()) {
-      // TODO: Error checking
       FormatAttr *Format = TargetDecl->getAttr<FormatAttr>();
       StringRef Type = Format->getType()->getName();
       std::string FormatIdx = std::to_string(Format->getFormatIdx());

clang/test/Sema/attr-modular-format.c

@@ -1,7 +1,5 @@
 //RUN: %clang_cc1 -fsyntax-only -verify %s
 
-#include <stdarg.h>
-
 int printf(const char *fmt, ...)  __attribute__((modular_format(__modular_printf, "__printf", "float")));  // no-error
 int myprintf(const char *fmt, ...)  __attribute__((modular_format(__modular_printf, "__printf", "float")));  // expected-error {{'modular_format' attribute requires 'format' attribute}}