Skip to content

Commit 0747d07

Browse files
committed
Give getLaterLoc() a comment and remove an unwanted test change.
1 parent 65df61f commit 0747d07

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8499,6 +8499,7 @@ SMLoc AMDGPUAsmParser::getInstLoc(const OperandVector &Operands) const {
84998499
return ((AMDGPUOperand &)*Operands[0]).getStartLoc();
85008500
}
85018501

8502+
// Returns one of the given locations that comes later in the source.
85028503
SMLoc AMDGPUAsmParser::getLaterLoc(SMLoc a, SMLoc b) {
85038504
return a.getPointer() < b.getPointer() ? b : a;
85048505
}

llvm/test/MC/AMDGPU/vop3-literal.s

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ v_div_fmas_f64 v[6:7], 0x12345678, 0x12345678, 0x12345678
488488
// GFX1250: v_div_fmas_f64 v[6:7], 0x12345678, 0x12345678, 0x12345678 ; encoding: [0x06,0x00,0x38,0xd6,0xff,0xfe,0xfd,0x03,0x78,0x56,0x34,0x12]
489489
// GFX9-ERR: :[[@LINE-3]]:24: error: literal operands are not supported
490490

491-
v_div_fmas_f64 v[4:5], v[1:2], 0x123457, 0x123456
491+
v_div_fmas_f64 v[4:5], v[2:3], 0x123457, 0x123456
492492
// GFX9-ERR: :[[@LINE-1]]:32: error: literal operands are not supported
493493
// GFX10-ERR: :[[@LINE-2]]:42: error: only one unique literal operand is allowed
494494
// GFX1250-ERR: :[[@LINE-3]]:42: error: only one unique literal operand is allowed

0 commit comments

Comments
 (0)