Address review comments.

Author: jimingham

lldb/include/lldb/Interpreter/Interfaces/ScriptedBreakpointInterface.h

@@ -1,4 +1,4 @@
-//===-- ScriptedBreakpointInterface.h -----------------------------*- C++ -*-===//
+//===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -11,14 +11,13 @@
 
 #include "lldb/lldb-private.h"
 #include "lldb/Symbol/SymbolContext.h"
-
 #include "ScriptedInterface.h"
 
 namespace lldb_private {
 class ScriptedBreakpointInterface : public ScriptedInterface {
 public:
   virtual llvm::Expected<StructuredData::GenericSP>
-  CreatePluginObject(llvm::StringRef class_name, lldb::BreakpointSP target_sp,
+  CreatePluginObject(llvm::StringRef class_name, lldb::BreakpointSP break_sp,
                      const StructuredDataImpl &args_sp) = 0;
 
   /// "ResolverCallback" will get called when a new module is loaded.  The

lldb/source/Breakpoint/BreakpointResolverScripted.cpp

@@ -62,7 +62,6 @@ void BreakpointResolverScripted::CreateImplementationIfNeeded(
       m_class_name, breakpoint_sp, m_args);
   if (!obj_or_err) {
     m_error = Status::FromError(obj_or_err.takeError());
-    printf("CreateImplementationIfNeeded got error: %s\n", m_error.AsCString());
     return;
   }
 

lldb/source/Interpreter/ScriptInterpreter.cpp

@@ -118,9 +118,8 @@ lldb::StreamSP ScriptInterpreter::GetOpaqueTypeFromSBStream(
 
 SymbolContext ScriptInterpreter::GetOpaqueTypeFromSBSymbolContext(
     const lldb::SBSymbolContext &sb_sym_ctx) const {
-  if (sb_sym_ctx.m_opaque_up) {
+  if (sb_sym_ctx.m_opaque_up)
     return *sb_sym_ctx.m_opaque_up.get();
-  }
   return {};
 }
 

lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedBreakpointPythonInterface.cpp

@@ -1,4 +1,4 @@
-//===-- ScriptedBreakpointPythonInterface.cpp -------------------------------===//
+//===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -15,10 +15,8 @@
 
 #if LLDB_ENABLE_PYTHON
 
-// clang-format off
 // LLDB Python header must be included first
 #include "../lldb-python.h"
-//clang-format on
 
 #include "../SWIGPythonBridge.h"
 #include "../ScriptInterpreterPythonImpl.h"
@@ -36,9 +34,8 @@ llvm::Expected<StructuredData::GenericSP>
 ScriptedBreakpointPythonInterface::CreatePluginObject(llvm::StringRef class_name,
                                                     lldb::BreakpointSP break_sp,
                                                     const StructuredDataImpl &args_sp) {
-  lldb::TargetSP target_sp;
   return ScriptedPythonInterface::CreatePluginObject(class_name, nullptr,
-                                                     break_sp /*target_sp*/, args_sp);
+                                                     break_sp, args_sp);
 }
 
 bool
@@ -49,7 +46,8 @@ ScriptedBreakpointPythonInterface::ResolverCallback(SymbolContext sym_ctx) {
 
   if (!ScriptedInterface::CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj,
                                                     error)) {
-    // FIXME: Should log the error here.
+    Log *log = GetLog(LLDBLog::Script);
+    LLDB_LOG(log, "Error calling __callback__ method: {1}", error); 
     return true;
   }
   return obj->GetBooleanValue();
@@ -86,7 +84,8 @@ std::optional<std::string> ScriptedBreakpointPythonInterface::GetShortHelp() {
 void ScriptedBreakpointPythonInterface::Initialize() {
   const std::vector<llvm::StringRef> ci_usages = {
       "breakpoint set -P classname [-k key -v value ...]"};
-  const std::vector<llvm::StringRef> api_usages = {};
+  const std::vector<llvm::StringRef> api_usages = {
+      "SBTarget.BreakpointCreateFromScript"};
   PluginManager::RegisterPlugin(
       GetPluginNameStatic(),
       llvm::StringRef("Create a breakpoint that chooses locations based on user-created callbacks"),