widenBuildVector - early out

RKSimon · RKSimon · commit 07cb6a223d59 · 2025-11-13T09:19:34.000Z
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -8910,13 +8910,11 @@ static SDValue widenBuildVector(BuildVectorSDNode *BVOp, SDLoc const &DL,
       continue;
     }
 
-    break;
+    return SDValue();
   }
 
-  if (WideOps.size() == (NumElts / 2))
-    return DAG.getBitcast(VT, DAG.getBuildVector(WideVT, DL, WideOps));
-
-  return SDValue();
+  assert(WideOps.size() == (NumElts / 2) && "Failed to widen build vector");
+  return DAG.getBitcast(VT, DAG.getBuildVector(WideVT, DL, WideOps));
 }
 
 /// Create a vector constant without a load. SSE/AVX provide the bare minimum

Original file line number	Diff line number	Diff line change
`@@ -8910,13 +8910,11 @@ static SDValue widenBuildVector(BuildVectorSDNode *BVOp, SDLoc const &DL,`
`8910`	`8910`	`continue;`
`8911`	`8911`	`}`
`8912`	`8912`
`8913`		`- break;`
	`8913`	`+ return SDValue();`
`8914`	`8914`	`}`
`8915`	`8915`
`8916`		`- if (WideOps.size() == (NumElts / 2))`
`8917`		`- return DAG.getBitcast(VT, DAG.getBuildVector(WideVT, DL, WideOps));`
`8918`		`-`
`8919`		`- return SDValue();`
	`8916`	`+ assert(WideOps.size() == (NumElts / 2) && "Failed to widen build vector");`
	`8917`	`+ return DAG.getBitcast(VT, DAG.getBuildVector(WideVT, DL, WideOps));`
`8920`	`8918`	`}`
`8921`	`8919`
`8922`	`8920`	`/// Create a vector constant without a load. SSE/AVX provide the bare minimum`