Revert "[sanitizer_common] AND signals in BlockSignals instead of deleting (#113443)"

This reverts commit 25fd366.

Reason: buildbot breakage (https://lab.llvm.org/buildbot/#/builders/186/builds/3642)

Author: thurstond

compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp

@@ -164,45 +164,33 @@ void SetSigProcMask(__sanitizer_sigset_t *set, __sanitizer_sigset_t *oldset) {
   CHECK_EQ(0, internal_sigprocmask(SIG_SETMASK, set, oldset));
 }
 
-// Deletes the specified signal from newset, if it is not present in oldset
-// Equivalently: newset[signum] = newset[signum] & oldset[signum]
-static void KeepUnblocked(__sanitizer_sigset_t &newset,
-                          __sanitizer_sigset_t &oldset, int signum) {
-  if (!internal_sigismember(&oldset, signum))
-    internal_sigdelset(&newset, signum);
-}
-
 // Block asynchronous signals
 void BlockSignals(__sanitizer_sigset_t *oldset) {
-  __sanitizer_sigset_t currentset;
-  SetSigProcMask(NULL, &currentset);
-
-  __sanitizer_sigset_t newset;
-  internal_sigfillset(&newset);
+  __sanitizer_sigset_t set;
+  internal_sigfillset(&set);
 #  if SANITIZER_LINUX && !SANITIZER_ANDROID
   // Glibc uses SIGSETXID signal during setuid call. If this signal is blocked
   // on any thread, setuid call hangs.
   // See test/sanitizer_common/TestCases/Linux/setuid.c.
-  KeepUnblocked(newset, currentset, 33);
+  internal_sigdelset(&set, 33);
 #  endif
 #  if SANITIZER_LINUX
   // Seccomp-BPF-sandboxed processes rely on SIGSYS to handle trapped syscalls.
   // If this signal is blocked, such calls cannot be handled and the process may
   // hang.
-  KeepUnblocked(newset, currentset, 31);
+  internal_sigdelset(&set, 31);
 
   // Don't block synchronous signals
-  // but also don't unblock signals that the user had deliberately blocked.
-  KeepUnblocked(newset, currentset, SIGSEGV);
-  KeepUnblocked(newset, currentset, SIGBUS);
-  KeepUnblocked(newset, currentset, SIGILL);
-  KeepUnblocked(newset, currentset, SIGTRAP);
-  KeepUnblocked(newset, currentset, SIGABRT);
-  KeepUnblocked(newset, currentset, SIGFPE);
-  KeepUnblocked(newset, currentset, SIGPIPE);
+  internal_sigdelset(&set, SIGSEGV);
+  internal_sigdelset(&set, SIGBUS);
+  internal_sigdelset(&set, SIGILL);
+  internal_sigdelset(&set, SIGTRAP);
+  internal_sigdelset(&set, SIGABRT);
+  internal_sigdelset(&set, SIGFPE);
+  internal_sigdelset(&set, SIGPIPE);
 #  endif
 
-  SetSigProcMask(&newset, oldset);
+  SetSigProcMask(&set, oldset);
 }
 
 ScopedBlockSignals::ScopedBlockSignals(__sanitizer_sigset_t *copy) {

compiler-rt/lib/sanitizer_common/tests/CMakeLists.txt

@@ -15,7 +15,6 @@ set(SANITIZER_UNITTESTS
   sanitizer_array_ref_test.cpp
   sanitizer_atomic_test.cpp
   sanitizer_bitvector_test.cpp
-  sanitizer_block_signals.cpp
   sanitizer_bvgraph_test.cpp
   sanitizer_chained_origin_depot_test.cpp
   sanitizer_common_test.cpp