Skip to content

Commit 086ac46

Browse files
committed
Make comments refer to lanes instead of threads where lanes are meant.
1 parent 8cf0cbf commit 086ac46

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

llvm/lib/Target/AMDGPU/AMDGPUAnnotateVaryingBranchWeights.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
//===----------------------------------------------------------------------===//
88
// Estimate if conditional branches for which SIAnnotateControlFlow introduced
99
// amdgcn_if or amdgcn_else intrinsics are likely to have different outcomes for
10-
// the threads of each wavefront. If that is the case, BranchWeight metadata is
10+
// the lanes of each wavefront. If that is the case, BranchWeight metadata is
1111
// added to signal that "then" and "else" blocks are both likely to be executed.
1212
// This may introduce branch weights that would be self-contradictory in a
1313
// non-SIMT setting.
1414
//
1515
// A consequence of this is that SIPreEmitPeephole is more likely to eliminate
1616
// s_cbranch_execz instructions that were introduced to skip these blocks when
17-
// no thread in the wavefront is active for them.
17+
// no lane in the wavefront is active for them.
1818
//
1919
// Should only run after SIAnnotateControlFlow.
2020
//===----------------------------------------------------------------------===//
@@ -218,7 +218,7 @@ bool AMDGPUAnnotateVaryingBranchWeightsImpl::run(Function &F) {
218218

219219
// reqd_work_group_size determines the size of the work group in every
220220
// dimension. If it is present, identify the dimensions where the workitem id
221-
// differs between the threads of the same wavefront. Otherwise assume that
221+
// differs between the lanes of the same wavefront. Otherwise assume that
222222
// only dimension 0, i.e., x, varies.
223223
//
224224
// TODO can/should we assume that workitems are grouped into waves like that?

0 commit comments

Comments
 (0)