Skip to content

Commit 08b2f33

Browse files
committed
Apply feedback
1 parent e081ff8 commit 08b2f33

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

clang/lib/AST/ExprConstant.cpp

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12318,14 +12318,13 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr *E) {
1231812318
case X86::BI__builtin_ia32_psignw256:
1231912319
case X86::BI__builtin_ia32_psignd128:
1232012320
case X86::BI__builtin_ia32_psignd256:
12321-
return EvaluateBinOpExpr(
12322-
[](const APInt &AElem, const APInt &BElem) -> APInt {
12323-
if (BElem.isZero())
12324-
return APInt::getZero(AElem.getBitWidth());
12325-
if (BElem.isNegative())
12326-
return -AElem;
12327-
return AElem;
12328-
});
12321+
return EvaluateBinOpExpr([](const APInt &AElem, const APInt &BElem) {
12322+
if (BElem.isZero())
12323+
return APInt::getZero(AElem.getBitWidth());
12324+
if (BElem.isNegative())
12325+
return -AElem;
12326+
return AElem;
12327+
});
1232912328

1233012329
case X86::BI__builtin_ia32_blendvpd:
1233112330
case X86::BI__builtin_ia32_blendvpd256:

clang/lib/Headers/tmmintrin.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@
2626
#define __zext128(x) \
2727
(__m128i) __builtin_shufflevector((__v2si)(x), __extension__(__v2si){}, 0, \
2828
1, 2, 3)
29-
#define __anyext128(x) \
30-
(__m128i) __builtin_shufflevector((__v2si)(x), __extension__(__v2si){}, 0, \
31-
1, -1, -1)
3229

3330
#if defined(__cplusplus) && (__cplusplus >= 201103L)
3431
#define __DEFAULT_FN_ATTRS_CONSTEXPR __DEFAULT_FN_ATTRS constexpr
@@ -774,7 +771,6 @@ static __inline__ __m64 __DEFAULT_FN_ATTRS_CONSTEXPR _mm_sign_pi32(__m64 __a,
774771
__builtin_ia32_psignd128((__v4si)__zext128(__a), (__v4si)__zext128(__b)));
775772
}
776773

777-
#undef __anyext128
778774
#undef __zext128
779775
#undef __trunc64
780776
#undef __DEFAULT_FN_ATTRS

0 commit comments

Comments
 (0)