small CR fixes

Author: eronnen

lldb/tools/lldb-dap/Handler/DisassembleRequestHandler.cpp

@@ -63,7 +63,7 @@ DisassembleRequestHandler::Run(const DisassembleArguments &args) const {
     return llvm::make_error<DAPError>(
         "Failed to find instructions for memory address.");
 
-  const bool resolveSymbols = args.resolveSymbols.value_or(false);
+  const bool resolve_symbols = args.resolveSymbols.value_or(false);
   const auto num_insts = insts.GetSize();
   for (size_t i = 0; i < num_insts; ++i) {
     lldb::SBInstruction inst = insts.GetInstructionAtIndex(i);
@@ -103,7 +103,7 @@ DisassembleRequestHandler::Run(const DisassembleArguments &args) const {
                                                 : symbol.GetName())
          << ": ";
 
-      if (resolveSymbols)
+      if (resolve_symbols)
         disassembled_inst.symbol = symbol.GetDisplayName();
     }
 

lldb/tools/lldb-dap/Protocol/ProtocolRequests.h

@@ -753,12 +753,15 @@ struct DisassembleArguments {
 };
 bool fromJSON(const llvm::json::Value &, DisassembleArguments &,
               llvm::json::Path);
+llvm::json::Value toJSON(const DisassembleArguments &);
 
 /// Response to `disassemble` request.
 struct DisassembleResponseBody {
   /// The list of disassembled instructions.
   std::vector<DisassembledInstruction> instructions;
 };
+bool fromJSON(const llvm::json::Value &, DisassembleResponseBody &,
+              llvm::json::Path);
 llvm::json::Value toJSON(const DisassembleResponseBody &);
 
 } // namespace lldb_dap::protocol

lldb/tools/lldb-dap/Protocol/ProtocolTypes.cpp

@@ -824,13 +824,13 @@ bool fromJSON(const llvm::json::Value &Params, DisassembledInstruction &DI,
   std::optional<llvm::StringRef> raw_address =
       Params.getAsObject()->getString("address");
   if (!raw_address) {
-    P.report("missing `address` field");
+    P.report("missing 'address' field");
     return false;
   }
 
   std::optional<lldb::addr_t> address = DecodeMemoryReference(*raw_address);
   if (!address) {
-    P.report("invalid `address`");
+    P.report("invalid 'address'");
     return false;
   }