[lldb] add test

Author: da-viper

lldb/include/lldb/Target/UnixSignals.h

@@ -31,7 +31,7 @@ class UnixSignals {
 
   llvm::StringRef GetSignalAsStringRef(int32_t signo) const;
 
-  llvm::StringRef GetSignalNoDescription(int32_t signo) const;
+  llvm::StringRef GetSignalNumberDescription(int32_t signo) const;
 
   std::string
   GetSignalDescription(int32_t signo,

lldb/source/Commands/CommandObjectProcess.cpp

@@ -1620,7 +1620,7 @@ class CommandObjectProcessHandle : public CommandObjectParsed {
                  (stop ? "true " : "false"), (notify ? "true " : "false"));
 
       llvm::StringRef sig_description =
-          signals_sp->GetSignalNoDescription(signo);
+          signals_sp->GetSignalNumberDescription(signo);
       if (!sig_description.empty()) {
         str.PutCString(" ");
         str.PutCString(sig_description);

lldb/source/Target/UnixSignals.cpp

@@ -137,7 +137,7 @@ llvm::StringRef UnixSignals::GetSignalAsStringRef(int32_t signo) const {
   return pos->second.m_name;
 }
 
-llvm::StringRef UnixSignals::GetSignalNoDescription(int32_t signo) const {
+llvm::StringRef UnixSignals::GetSignalNumberDescription(int32_t signo) const {
   const auto pos = m_signals.find(signo);
   if (pos == m_signals.end())
     return {};

lldb/unittests/Signals/UnixSignalsTest.cpp

@@ -148,6 +148,18 @@ TEST(UnixSignalsTest, GetAsString) {
             signals.GetSignalDescription(16, 3, 0x1233, 0x1234, 0x5678));
 }
 
+TEST(UnixSignalsTest, GetNumberDescription) {
+  TestSignals signals;
+
+  ASSERT_EQ("DESC2", signals.GetSignalNumberDescription(2));
+  ASSERT_EQ("DESC4", signals.GetSignalNumberDescription(4));
+  ASSERT_EQ("DESC8", signals.GetSignalNumberDescription(8));
+  ASSERT_EQ("DESC16", signals.GetSignalNumberDescription(16));
+
+  // Unknown signal number.
+  ASSERT_EQ("", signals.GetSignalNumberDescription(100));
+}
+
 TEST(UnixSignalsTest, VersionChange) {
   TestSignals signals;