Skip to content

Commit 08f1082

Browse files
committed
[mlir][nfc] move early exit from later to early
1 parent f10a905 commit 08f1082

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1682,6 +1682,10 @@ struct ViewOpLowering : public ConvertOpToLLVMPattern<memref::ViewOp> {
16821682
LogicalResult
16831683
matchAndRewrite(memref::ViewOp viewOp, OpAdaptor adaptor,
16841684
ConversionPatternRewriter &rewriter) const override {
1685+
// Early exit for 0-D corner case.
1686+
if (viewMemRefType.getRank() == 0)
1687+
return rewriter.replaceOp(viewOp, {targetMemRef}), success();
1688+
16851689
auto loc = viewOp.getLoc();
16861690

16871691
auto viewMemRefType = viewOp.getType();
@@ -1733,10 +1737,6 @@ struct ViewOpLowering : public ConvertOpToLLVMPattern<memref::ViewOp> {
17331737
rewriter, loc,
17341738
createIndexAttrConstant(rewriter, loc, indexType, offset));
17351739

1736-
// Early exit for 0-D corner case.
1737-
if (viewMemRefType.getRank() == 0)
1738-
return rewriter.replaceOp(viewOp, {targetMemRef}), success();
1739-
17401740
// Fields 4 and 5: Update sizes and strides.
17411741
Value stride = nullptr, nextSize = nullptr;
17421742
for (int i = viewMemRefType.getRank() - 1; i >= 0; --i) {

0 commit comments

Comments
 (0)