Skip to content

Commit 0944417

Browse files
committed
[JIT] Fix crash in unit tests
The unit tests `ReOptimizeLayerTest.BasicReOptimization` and `JITLinkRedirectionManagerTest.BasicRedirectionOperation` are failing for me with the error: ``` Program aborted due to an unhandled Error: Error value was Success. (Note: Success values must still be checked prior to being destroyed). ``` The error is raised when a value is assigned to `Err`, due to the the missing `ErrorAsOutParameter`.
1 parent 2002533 commit 0944417

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

llvm/include/llvm/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ class JITLinkRedirectableSymbolManager : public RedirectableSymbolManager,
5959
ObjLinkingLayer.getExecutionSession().getTargetTriple())),
6060
PtrJumpStubCreator(jitlink::getPointerJumpStubCreator(
6161
ObjLinkingLayer.getExecutionSession().getTargetTriple())) {
62+
ErrorAsOutParameter _(&Err);
6263
if (!AnonymousPtrCreator || !PtrJumpStubCreator)
6364
Err = make_error<StringError>("Architecture not supported",
6465
inconvertibleErrorCode());

0 commit comments

Comments
 (0)