Skip to content

Commit 0958eaf

Browse files
committed
Update comments
1 parent a9ce4c3 commit 0958eaf

File tree

5 files changed

+11
-10
lines changed

5 files changed

+11
-10
lines changed

mlir/include/mlir/Interfaces/ParallelCombiningOpInterface.td

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
//
77
//===----------------------------------------------------------------------===//
88
//
9-
// Defines the interface for ops that perform parallel combining operations.
9+
// Defines the interface for ops that perform in parallel combining
10+
// operations.
1011
//
1112
//===----------------------------------------------------------------------===//
1213

@@ -17,7 +18,7 @@ include "mlir/IR/OpBase.td"
1718

1819
def InParallelOpInterface : OpInterface<"InParallelOpInterface"> {
1920
let description = [{
20-
A parallel combining op is an op with a region.
21+
An in parallel op is an op with a region.
2122

2223
This is useful as a terminator to parallel operations that iterate over
2324
some set and return tensors while avoiding tight coupling between the
@@ -58,7 +59,7 @@ def InParallelOpInterface : OpInterface<"InParallelOpInterface"> {
5859

5960
def ParallelCombiningOpInterface : OpInterface<"ParallelCombiningOpInterface"> {
6061
let description = [{
61-
An `in_parallel` op is an operation performs parallel updates to
62+
A parallel combining op is an operation performs parallel updates to
6263
destination tensors within the context of a parent iterating operation.
6364

6465
This interface is designed for operations that need to coordinate parallel
@@ -73,8 +74,8 @@ def ParallelCombiningOpInterface : OpInterface<"ParallelCombiningOpInterface"> {
7374
this interface, other operations that perform similar parallel updates can
7475
also be defined.
7576

76-
The in_parallel operation works within a combining operation (implementing
77-
`ParallelCombiningOpInterface`) that specifies how the parallel results are combined.
77+
This op works within an op implementing the
78+
`InParallelOpInterface` that specifies how the parallel results are combined.
7879

7980
Key semantics:
8081
- The operation identifies destination tensors that will be updated

mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4141,7 +4141,7 @@ DiagnosedSilenceableFailure doit(RewriterBase &rewriter, OpTy target,
41414141
return DiagnosedSilenceableFailure::success();
41424142
}
41434143

4144-
// If we are inside a `InParallelOp` region, temporarily set the
4144+
// If we are inside a `ParallelCombiningOp` region, temporarily set the
41454145
// insertion point outside: only ops implementing ParallelCombiningOpInterface are
41464146
// allowed in there.
41474147
if (isa<mlir::ParallelCombiningOpInterface>(target.getOperation())) {

mlir/lib/Dialect/Tensor/IR/TensorOps.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2976,7 +2976,7 @@ class InsertSliceOpConstantArgumentFolder final
29762976
if (sourceType != insertSliceOp.getSourceType()) {
29772977
OpBuilder::InsertionGuard g(rewriter);
29782978
// The only difference between InsertSliceOp and ParallelInsertSliceOp
2979-
// is that the insertion point is just before the ParallelCombiningOp in
2979+
// is that the insertion point is just before the InParallelOp in
29802980
// the parallel case.
29812981
if (isa<InParallelOpInterface>(insertSliceOp->getParentOp()))
29822982
rewriter.setInsertionPoint(insertSliceOp->getParentOp());
@@ -3153,7 +3153,7 @@ struct InsertSliceOpSourceCastInserter final
31533153
// Insert the cast.
31543154
OpBuilder::InsertionGuard g(rewriter);
31553155
// The only difference between InsertSliceOp and ParallelInsertSliceOp is
3156-
// that the insertion point is just before the ParallelCombiningOp in the
3156+
// that the insertion point is just before the InParallelOp in the
31573157
// parallel case.
31583158
if (isa<ParallelCombiningOpInterface>(insertSliceOp->getParentOp()))
31593159
rewriter.setInsertionPoint(insertSliceOp->getParentOp());

mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -973,7 +973,7 @@ struct ParallelInsertSliceOpInterface
973973
InParallelOpInterface parallelCombiningParent =
974974
parallelInsertSliceOp.getParallelCombiningParent();
975975

976-
// Bufferize the op outside of the parallel combining terminator.
976+
// Bufferize the op outside of the in parallel terminator.
977977
rewriter.setInsertionPoint(parallelCombiningParent);
978978

979979
// Get source and destination buffers.

mlir/lib/Dialect/Tensor/Transforms/FoldTensorSubsetOps.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ struct InsertSliceOfInsertSliceFolder : public OpRewritePattern<OpTy> {
215215
sourceInsertSliceOp.getMixedSizes(),
216216
droppedDims, resolvedSizes);
217217

218-
// If we are inside an InParallel region, temporarily set the insertion
218+
// If we are inside a ParallelCombining region, temporarily set the insertion
219219
// point outside: only ops of ParallelCombiningOpInterface are allowed in
220220
// there.
221221
if (isa<mlir::ParallelCombiningOpInterface>(insertSliceOp.getOperation())) {

0 commit comments

Comments
 (0)