Skip to content

Commit 0a6730d

Browse files
committed
Address review comments
1 parent 29349d7 commit 0a6730d

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

llvm/include/llvm/CodeGen/BasicTTIImpl.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1472,8 +1472,10 @@ class BasicTTIImplBase : public TargetTransformInfoImplCRTPBase<T> {
14721472
InstructionCost getExpandCompressMemoryOpCost(
14731473
unsigned Opcode, Type *DataTy, bool VariableMask, Align Alignment,
14741474
TTI::TargetCostKind CostKind, const Instruction *I = nullptr) {
1475+
// Treat expand load/compress store as gather/scatter operation.
1476+
// TODO: implement more precise cost estimation for these intrinsics.
14751477
return getCommonMaskedMemoryOpCost(Opcode, DataTy, Alignment, VariableMask,
1476-
true, CostKind);
1478+
/*IsGatherScatter*/ true, CostKind);
14771479
}
14781480

14791481
InstructionCost getStridedMemoryOpCost(unsigned Opcode, Type *DataTy,

llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -862,7 +862,8 @@ InstructionCost RISCVTTIImpl::getExpandCompressMemoryOpCost(
862862
// vsetivli zero, 8, e32, m2, ta, ma
863863
// viota.m v12, v0
864864
// vrgather.vv v8, v10, v12, v0.t
865-
auto MemOpCost = getMemoryOpCost(Opcode, DataTy, Alignment, 0, CostKind);
865+
auto MemOpCost =
866+
getMemoryOpCost(Opcode, DataTy, Alignment, /*AddressSpace*/ 0, CostKind);
866867
auto LT = getTypeLegalizationCost(DataTy);
867868
SmallVector<unsigned, 4> Opcodes{RISCV::VSETVLI};
868869
if (VariableMask)

0 commit comments

Comments
 (0)