Include plugin info in stats

Author: dmpots

lldb/include/lldb/Target/Statistics.h

@@ -174,12 +174,21 @@ struct StatisticsOptions {
     return !GetSummaryOnly();
   }
 
+  void SetIncludePlugins(bool value) { m_include_plugins = value; }
+  bool GetIncludePlugins() const {
+    if (m_include_plugins.has_value())
+      return m_include_plugins.value();
+    // Default to true in both default mode and summary mode.
+    return true;
+  }
+
 private:
   std::optional<bool> m_summary_only;
   std::optional<bool> m_load_all_debug_info;
   std::optional<bool> m_include_targets;
   std::optional<bool> m_include_modules;
   std::optional<bool> m_include_transcript;
+  std::optional<bool> m_include_plugins;
 };
 
 /// A class that represents statistics about a TypeSummaryProviders invocations

lldb/source/Commands/CommandObjectStats.cpp

@@ -103,6 +103,13 @@ class CommandObjectStatsDump : public CommandObjectParsed {
         else
           error = Status::FromError(bool_or_error.takeError());
         break;
+      case 'p':
+        if (llvm::Expected<bool> bool_or_error =
+                OptionArgParser::ToBoolean("--plugins", option_arg))
+          m_stats_options.SetIncludePlugins(*bool_or_error);
+        else
+          error = Status::FromError(bool_or_error.takeError());
+        break;
       default:
         llvm_unreachable("Unimplemented option");
       }

lldb/source/Commands/Options.td

@@ -1467,5 +1467,9 @@ let Command = "statistics dump" in {
     "scripts executed during a debug session. "
     "Defaults to true, unless the '--summary' mode is enabled, in which case "
     "this is turned off unless specified.">;
+  def statistics_dump_plugins: Option<"plugins", "p">, Group<1>,
+    Arg<"Boolean">,
+    Desc<"Dump statistics for known plugins including name, order, and enabled "
+    "state. Defaults to true for both summary and default mode.">;
 
 }

lldb/source/Target/Statistics.cpp

@@ -10,6 +10,7 @@
 
 #include "lldb/Core/Debugger.h"
 #include "lldb/Core/Module.h"
+#include "lldb/Core/PluginManager.h"
 #include "lldb/Interpreter/CommandInterpreter.h"
 #include "lldb/Symbol/SymbolFile.h"
 #include "lldb/Target/DynamicLoader.h"
@@ -285,6 +286,7 @@ llvm::json::Value DebuggerStats::ReportStatistics(
   const bool include_targets = options.GetIncludeTargets();
   const bool include_modules = options.GetIncludeModules();
   const bool include_transcript = options.GetIncludeTranscript();
+  const bool include_plugins = options.GetIncludePlugins();
 
   json::Array json_targets;
   json::Array json_modules;
@@ -464,6 +466,23 @@ llvm::json::Value DebuggerStats::ReportStatistics(
     }
   }
 
+  if (include_plugins) {
+    json::Object plugin_stats;
+    for (const PluginNamespace &plugin_ns : PluginManager::GetPluginNamespaces()) {
+      json::Array namespace_stats;
+
+      for (const RegisteredPluginInfo &plugin : plugin_ns.get_info()) {
+        json::Object plugin_json;
+        plugin_json.try_emplace("name", plugin.name);
+        plugin_json.try_emplace("enabled", plugin.enabled);
+
+        namespace_stats.emplace_back(std::move(plugin_json));
+      }
+      plugin_stats.try_emplace(plugin_ns.name, std::move(namespace_stats));
+    }
+    global_stats.try_emplace("plugins", std::move(plugin_stats));
+  }
+
   return std::move(global_stats);
 }