Skip to content

Commit 0b8f561

Browse files
committed
Update verifier message
1 parent 9860cdd commit 0b8f561

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mlir/lib/Dialect/AMDGPU/IR/AMDGPUDialect.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -374,8 +374,8 @@ LogicalResult ScaledExtPacked816Op::verify() {
374374
bool is_valid = ((firstScaleLane == 0) && (firstScaleByte == 0)) ||
375375
((firstScaleLane == 1) && (firstScaleByte == 2));
376376
if (!is_valid) {
377-
return emitOpError(
378-
"blockSize of 16 can only have firstScaleByte be 0 or 2 for f8.");
377+
return emitOpError("blockSize of 16 can only have (firstScaleLane, "
378+
"firstScaleByte) be (0, 0) or (1, 2) for f8.");
379379
}
380380
}
381381
}

mlir/test/Conversion/AMDGPUToROCDL/cvt_scale_pk-gfx1250.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ func.func @amdgpu.scaled_ext_packed816_invalid_block_size_and_first_scale_byte_3
134134
// -----
135135

136136
func.func @amdgpu.scaled_ext_packed816_invalid_attributes_for_f8(%v: vector<8xf8E5M2>, %scale: vector<4xf8E8M0FNU>) {
137-
// expected-error@+1 {{'amdgpu.scaled_ext_packed816' op blockSize of 16 can only have firstScaleByte be 0 or 2 for f8.}}
137+
// expected-error@+1 {{'amdgpu.scaled_ext_packed816' op blockSize of 16 can only have (firstScaleLane, firstScaleByte) be (0, 0) or (1, 2) for f8.}}
138138
%ret0 = amdgpu.scaled_ext_packed816 %v scale(%scale) blockSize(16) firstScaleLane(0) firstScaleByte(1) : vector<8xf8E5M2>, vector<4xf8E8M0FNU> -> vector<8xf16>
139139
func.return
140140
}

0 commit comments

Comments
 (0)