Review feedback

Author: jurahul

llvm/include/llvm/CodeGen/MachineFunction.h

@@ -239,12 +239,6 @@ class MachineFunctionProperties {
     return *this;
   }
 
-  // Set all the properties.
-  MachineFunctionProperties &set() {
-    Properties.set();
-    return *this;
-  }
-
   MachineFunctionProperties &set(const MachineFunctionProperties &MFP) {
     Properties |= MFP.Properties;
     return *this;

llvm/lib/Passes/PassBuilder.cpp

@@ -465,7 +465,18 @@ class RequireAllMachineFunctionPropertiesPass
   }
 
   static MachineFunctionProperties getRequiredProperties() {
-    return MachineFunctionProperties().set();
+    return MachineFunctionProperties()
+        .setFailedISel()
+        .setFailsVerification()
+        .setIsSSA()
+        .setLegalized()
+        .setNoPHIs()
+        .setNoVRegs()
+        .setRegBankSelected()
+        .setSelected()
+        .setTiedOpsRewritten()
+        .setTracksDebugUserValues()
+        .setTracksLiveness();
   }
   static StringRef name() { return "RequireAllMachineFunctionPropertiesPass"; }
 };