Use appropriate name for input ID type diagnose function

Author: Zhengxing Li

clang/include/clang/Sema/SemaHLSL.h

@@ -137,7 +137,8 @@ class SemaHLSL : public SemaBase {
 
   bool CheckCompatibleParameterABI(FunctionDecl *New, FunctionDecl *Old);
 
-  bool isLegalTypeForHLSLSV_ThreadOrGroupID(QualType T, const ParsedAttr &AL);
+  // Diagnose whether the input ID is uint/unit2/uint3 type.
+  bool diagnoseInputIDType(QualType T, const ParsedAttr &AL);
 
   ExprResult ActOnOutParamExpr(ParmVarDecl *Param, Expr *Arg);
 

clang/lib/Sema/SemaHLSL.cpp

@@ -765,8 +765,7 @@ void SemaHLSL::handleWaveSizeAttr(Decl *D, const ParsedAttr &AL) {
     D->addAttr(NewAttr);
 }
 
-bool SemaHLSL::isLegalTypeForHLSLSV_ThreadOrGroupID(QualType T,
-                                                    const ParsedAttr &AL) {
+bool SemaHLSL::diagnoseInputIDType(QualType T, const ParsedAttr &AL) {
   const auto *VT = T->getAs<VectorType>();
 
   if (!T->hasUnsignedIntegerRepresentation() ||
@@ -781,7 +780,7 @@ bool SemaHLSL::isLegalTypeForHLSLSV_ThreadOrGroupID(QualType T,
 
 void SemaHLSL::handleSV_DispatchThreadIDAttr(Decl *D, const ParsedAttr &AL) {
   auto *VD = cast<ValueDecl>(D);
-  if (!isLegalTypeForHLSLSV_ThreadOrGroupID(VD->getType(), AL))
+  if (!diagnoseInputIDType(VD->getType(), AL))
     return;
 
   D->addAttr(::new (getASTContext())
@@ -790,7 +789,7 @@ void SemaHLSL::handleSV_DispatchThreadIDAttr(Decl *D, const ParsedAttr &AL) {
 
 void SemaHLSL::handleSV_GroupIDAttr(Decl *D, const ParsedAttr &AL) {
   auto *VD = cast<ValueDecl>(D);
-  if (!isLegalTypeForHLSLSV_ThreadOrGroupID(VD->getType(), AL))
+  if (!diagnoseInputIDType(VD->getType(), AL))
     return;
 
   D->addAttr(::new (getASTContext()) HLSLSV_GroupIDAttr(getASTContext(), AL));