reordered shouldMoveOutofRegion condition checks for LICM

mbagherbeikTT · mbagherbeikTT · commit 0c23f0ccb2e4 · 2025-08-13T20:10:49.000Z
diff --git a/mlir/lib/Transforms/Utils/LoopInvariantCodeMotionUtils.cpp b/mlir/lib/Transforms/Utils/LoopInvariantCodeMotionUtils.cpp
@@ -110,7 +110,7 @@ size_t mlir::moveLoopInvariantCode(LoopLikeOpInterface loopLike) {
         return loopLike.isDefinedOutsideOfLoop(value);
       },
       [&](Operation *op, Region *) {
-        return isMemoryEffectMovable(op) && isSpeculatable(op);
+        return isSpeculatable(op) && isMemoryEffectMovable(op);
       },
       [&](Operation *op, Region *) { loopLike.moveOutOfLoop(op); });
 }

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ size_t mlir::moveLoopInvariantCode(LoopLikeOpInterface loopLike) {`
`110`	`110`	`return loopLike.isDefinedOutsideOfLoop(value);`
`111`	`111`	`},`
`112`	`112`	`[&](Operation op, Region ) {`
`113`		`- return isMemoryEffectMovable(op) && isSpeculatable(op);`
	`113`	`+ return isSpeculatable(op) && isMemoryEffectMovable(op);`
`114`	`114`	`},`
`115`	`115`	`[&](Operation op, Region ) { loopLike.moveOutOfLoop(op); });`
`116`	`116`	`}`