Skip to content

Commit 0c2bfc7

Browse files
committed
Update for reviewer comments
- Fix typo in comment - Add release notes entry
1 parent f9dcba2 commit 0c2bfc7

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,11 @@ Improvements to Clang's diagnostics
332332
properly being rejected when used at compile-time. It was not implemented
333333
and caused assertion failures before (#GH158471).
334334

335+
- Closed a loophole in the diagnosis of function pointer conversions changing
336+
extended function type information in C mode (#GH41465). Function conversions
337+
that were previously incorrectly accepted in case of other irrelevant
338+
conditions are now consistently diagnosed, identical to C++ mode.
339+
335340
Improvements to Clang's time-trace
336341
----------------------------------
337342

clang/include/clang/Sema/Sema.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10209,7 +10209,7 @@ class Sema final : public SemaBase {
1020910209

1021010210
/// Determine whether the conversion from FromType to ToType is a valid
1021110211
/// conversion of ExtInfo/ExtProtoInfo on the nested function type.
10212-
/// More precisely, this method checks whether FromType can be tranformed
10212+
/// More precisely, this method checks whether FromType can be transformed
1021310213
/// into an exact match for ToType, by transforming its extended function
1021410214
/// type information in legal manner (e.g. by strictly stripping "noreturn"
1021510215
/// or "noexcept", or by stripping "noescape" for arguments).

0 commit comments

Comments
 (0)