Skip to content

Commit 0c2e900

Browse files
authored
[SystemZ] Fix variable names to reflect Coding Standards (#161899)
Reflecting the [Coding Standards](https://llvm.org/docs/CodingStandards.html), the following changes were made to reflect this guideline. ``` Variable names should be nouns (as they represent state). The name should be camel case, and start with an upper-case letter (e.g. Leader or Boats). ``` The first letter in the variable names are changed to upper-case and reflect being camel case.
1 parent 121026b commit 0c2e900

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,8 @@ void SystemZInstPrinterCommon::printPCRelTLSOperand(const MCInst *MI,
184184
// Output the TLS marker if present.
185185
if ((unsigned)OpNum + 1 < MI->getNumOperands()) {
186186
const MCOperand &MO = MI->getOperand(OpNum + 1);
187-
const MCSymbolRefExpr &refExp = cast<MCSymbolRefExpr>(*MO.getExpr());
188-
switch (refExp.getSpecifier()) {
187+
const MCSymbolRefExpr &RefExp = cast<MCSymbolRefExpr>(*MO.getExpr());
188+
switch (RefExp.getSpecifier()) {
189189
case SystemZ::S_TLSGD:
190190
O << ":tls_gdcall:";
191191
break;
@@ -195,7 +195,7 @@ void SystemZInstPrinterCommon::printPCRelTLSOperand(const MCInst *MI,
195195
default:
196196
llvm_unreachable("Unexpected symbol kind");
197197
}
198-
O << refExp.getSymbol().getName();
198+
O << RefExp.getSymbol().getName();
199199
}
200200
}
201201

llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,9 @@
1313

1414
using namespace llvm;
1515

16-
SystemZConstantPoolValue::
17-
SystemZConstantPoolValue(const GlobalValue *gv,
18-
SystemZCP::SystemZCPModifier modifier)
19-
: MachineConstantPoolValue(gv->getType()), GV(gv), Modifier(modifier) {}
16+
SystemZConstantPoolValue::SystemZConstantPoolValue(
17+
const GlobalValue *GV, SystemZCP::SystemZCPModifier Modifier)
18+
: MachineConstantPoolValue(GV->getType()), GV(GV), Modifier(Modifier) {}
2019

2120
SystemZConstantPoolValue *
2221
SystemZConstantPoolValue::Create(const GlobalValue *GV,

llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -352,10 +352,9 @@ int SystemZHazardRecognizer::groupingCost(SUnit *SU) const {
352352
// Similarly, a group-ending SU may either fit well (last in group), or
353353
// end the group prematurely.
354354
if (SC->EndGroup) {
355-
unsigned resultingGroupSize =
356-
(CurrGroupSize + getNumDecoderSlots(SU));
357-
if (resultingGroupSize < 3)
358-
return (3 - resultingGroupSize);
355+
unsigned ResultingGroupSize = (CurrGroupSize + getNumDecoderSlots(SU));
356+
if (ResultingGroupSize < 3)
357+
return (3 - ResultingGroupSize);
359358
return -1;
360359
}
361360

0 commit comments

Comments
 (0)