Move SymbolizeStackElems into OutputReport

Author: DanBlackwell

compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp

@@ -2146,7 +2146,6 @@ static void ReportErrnoSpoiling(ThreadState *thr, uptr pc, int sig) {
   rep.SetSigNum(sig);
   if (!IsFiredSuppression(ctx, ReportTypeErrnoInSignal, stack)) {
     rep.AddStack(stack, true);
-    rep.SymbolizeStackElems();
     OutputReport(thr, rep);
   }
 }

compiler-rt/lib/tsan/rtl/tsan_interface_ann.cpp

@@ -446,7 +446,6 @@ static void ReportMutexHeldWrongContext(ThreadState *thr, uptr pc) {
   VarSizeStackTrace trace;
   ObtainCurrentStack(thr, pc, &trace);
   rep.AddStack(trace, true);
-  rep.SymbolizeStackElems();
   OutputReport(thr, rep);
 }
 

compiler-rt/lib/tsan/rtl/tsan_mman.cpp

@@ -185,7 +185,6 @@ static void SignalUnsafeCall(ThreadState *thr, uptr pc) {
   ThreadRegistryLock l(&ctx->thread_registry);
   ScopedReport rep(ReportTypeSignalUnsafe);
   rep.AddStack(stack, true);
-  rep.SymbolizeStackElems();
   OutputReport(thr, rep);
 }
 

compiler-rt/lib/tsan/rtl/tsan_rtl.h

@@ -499,7 +499,7 @@ void ForkChildAfter(ThreadState *thr, uptr pc, bool start_thread);
 
 void ReportRace(ThreadState *thr, RawShadow *shadow_mem, Shadow cur, Shadow old,
                 AccessType typ);
-bool OutputReport(ThreadState *thr, const ScopedReport &srep);
+bool OutputReport(ThreadState *thr, ScopedReport &srep);
 bool IsFiredSuppression(Context *ctx, ReportType type, StackTrace trace);
 bool IsExpectedReport(uptr addr, uptr size);
 

compiler-rt/lib/tsan/rtl/tsan_rtl_mutex.cpp

@@ -62,7 +62,6 @@ static void ReportMutexMisuse(ThreadState *thr, uptr pc, ReportType typ,
   ObtainCurrentStack(thr, pc, &trace);
   rep.AddStack(trace, true);
   rep.AddLocation(addr, 1);
-  rep.SymbolizeStackElems();
   OutputReport(thr, rep);
 }
 
@@ -551,7 +550,6 @@ void ReportDeadlock(ThreadState *thr, uptr pc, DDReport *r) {
       rep.AddStack(stack, true);
     }
   }
-  rep.SymbolizeStackElems();
   OutputReport(thr, rep);
 }
 
@@ -576,7 +574,6 @@ void ReportDestroyLocked(ThreadState *thr, uptr pc, uptr addr,
     return;
   rep.AddStack(trace, true);
   rep.AddLocation(addr, 1);
-  rep.SymbolizeStackElems();
   OutputReport(thr, rep);
 }
 

compiler-rt/lib/tsan/rtl/tsan_rtl_report.cpp

@@ -672,11 +672,12 @@ static bool HandleRacyStacks(ThreadState *thr, VarSizeStackTrace traces[2]) {
   return false;
 }
 
-bool OutputReport(ThreadState *thr, const ScopedReport &srep) {
+bool OutputReport(ThreadState *thr, ScopedReport &srep) {
   // These should have been checked in ShouldReport.
   // It's too late to check them here, we have already taken locks.
   CHECK(flags()->report_bugs);
   CHECK(!thr->suppress_reports);
+  srep.SymbolizeStackElems();
   atomic_store_relaxed(&ctx->last_symbolize_time_ns, NanoTime());
   const ReportDesc *rep = srep.GetReport();
   CHECK_EQ(thr->current_report, nullptr);
@@ -863,7 +864,6 @@ void ReportRace(ThreadState *thr, RawShadow *shadow_mem, Shadow cur, Shadow old,
       s[1].epoch() <= thr->last_sleep_clock.Get(s[1].sid()))
     rep.AddSleep(thr->last_sleep_stack_id);
 #endif
-  rep.SymbolizeStackElems();
   OutputReport(thr, rep);
 }
 

compiler-rt/lib/tsan/rtl/tsan_rtl_thread.cpp

@@ -96,7 +96,6 @@ void ThreadFinalize(ThreadState *thr) {
     ScopedReport rep(ReportTypeThreadLeak);
     rep.AddThread(leaks[i].tctx, true);
     rep.SetCount(leaks[i].count);
-    rep.SymbolizeStackElems();
     OutputReport(thr, rep);
   }
 #endif