Change terminology "obtaining address of" -> "taking address of"

The wording "take address of" or "taking address of" is more common
across the codebase:

% git grep 'tak\(e\|ing\) address of' | wc
    107    1513   16080

Whereas the wording "obtaining address of" has no occurrence. Use the
more common wording.

Author: melver

clang/docs/ReleaseNotes.rst

@@ -789,7 +789,7 @@ Improvements to Clang's diagnostics
     }
 
 - The :doc:`ThreadSafetyAnalysis` now supports ``-Wthread-safety-addressof``,
-  which enables warning if the address of guarded variables is obtained.
+  which enables warning on taking the address of guarded variables.
 
 Improvements to Clang's time-trace
 ----------------------------------

clang/include/clang/Analysis/Analyses/ThreadSafety.h

@@ -55,7 +55,7 @@ enum ProtectedOperationKind {
   /// Returning a pt-guarded variable by reference.
   POK_PtReturnByRef,
 
-  /// Obtaining address of a variable (e.g. &x).
+  /// Taking address of a variable (e.g. &x).
   POK_AddressOf,
 };
 

clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -4142,10 +4142,10 @@ def note_guarded_by_declared_here : Note<"guarded_by declared here">;
 
 // Thread safety warnings on addressof
 def warn_addressof_requires_any_lock : Warning<
-  "obtaining address of variable %0 requires holding any mutex">,
+  "taking address of variable %0 requires holding any mutex">,
   InGroup<ThreadSafetyAddressof>, DefaultIgnore;
 def warn_addressof_requires_lock : Warning<
-  "obtaining address of variable %1 requires holding %0 '%2'">,
+  "taking address of variable %1 requires holding %0 '%2'">,
   InGroup<ThreadSafetyAddressof>, DefaultIgnore;
 
 // Dummy warning that will trigger "beta" warnings from the analysis if enabled.

clang/test/Sema/warn-thread-safety-analysis.c

@@ -136,7 +136,7 @@ int main(void) {
 
 #ifdef CHECK_ADDRESSOF
   set_value(&a_, 0); // expected-warning{{calling function 'set_value' requires holding mutex 'foo_.mu_' exclusively}} \
-                        expected-warning{{obtaining address of variable 'a_' requires holding mutex 'foo_.mu_'}}
+                        expected-warning{{taking address of variable 'a_' requires holding mutex 'foo_.mu_'}}
 #else
   set_value(&a_, 0); // expected-warning{{calling function 'set_value' requires holding mutex 'foo_.mu_' exclusively}}
 #endif
@@ -187,7 +187,7 @@ int main(void) {
   late_parsing.a_value_defined_before = 1; // expected-warning{{writing variable 'a_value_defined_before' requires holding mutex 'a_mutex_defined_late' exclusively}}
   late_parsing.a_ptr_defined_before = 0;
 # ifdef CHECK_ADDRESSOF
-  (void)&late_parsing.a_value_defined_before; // expected-warning{{obtaining address of variable 'a_value_defined_before' requires holding mutex 'a_mutex_defined_late'}}
+  (void)&late_parsing.a_value_defined_before; // expected-warning{{taking address of variable 'a_value_defined_before' requires holding mutex 'a_mutex_defined_late'}}
 # else
   (void)&late_parsing.a_value_defined_before; // no warning
 # endif

clang/test/SemaCXX/warn-thread-safety-analysis.cpp

@@ -4953,8 +4953,8 @@ class Foo {
     --data_;              // expected-warning {{writing variable 'data_' requires holding mutex 'mu_' exclusively}}
     data_--;              // expected-warning {{writing variable 'data_' requires holding mutex 'mu_' exclusively}}
 #ifdef CHECK_ADDRESSOF
-    (void)&data_;         // expected-warning {{obtaining address of variable 'data_' requires holding mutex 'mu_'}}
-    (void)&datap1_;       // expected-warning {{obtaining address of variable 'datap1_' requires holding mutex 'mu_'}}
+    (void)&data_;         // expected-warning {{taking address of variable 'data_' requires holding mutex 'mu_'}}
+    (void)&datap1_;       // expected-warning {{taking address of variable 'datap1_' requires holding mutex 'mu_'}}
 #else
     (void)&data_;         // no warning
     (void)&datap1_;       // no warning
@@ -5903,7 +5903,7 @@ class Foo {
 
   void ptr_test() {
 #ifdef CHECK_ADDRESSOF
-    int *b = &a;           // expected-warning {{obtaining address of variable 'a' requires holding mutex 'mu'}}
+    int *b = &a;           // expected-warning {{taking address of variable 'a' requires holding mutex 'mu'}}
 #else
     int *b = &a;           // no warning
 #endif
@@ -6126,7 +6126,7 @@ class Return {
 
   Foo *returns_ptr() {
 #ifdef CHECK_ADDRESSOF
-    return &foo;              // expected-warning {{obtaining address of variable 'foo' requires holding mutex 'mu'}}
+    return &foo;              // expected-warning {{taking address of variable 'foo' requires holding mutex 'mu'}}
 #else
     return &foo;              // no warning
 #endif