Skip to content

Commit 0c570c8

Browse files
author
joaosaffran
committed
adding requested comment
1 parent 7f70dc5 commit 0c570c8

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

llvm/lib/Target/DirectX/DXILRootSignature.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,8 @@ static bool parseRootDescriptors(LLVMContext *Ctx,
129129
return reportError(Ctx, "Root Descriptor, first element is not a string.");
130130

131131
dxbc::RTS0::v1::RootParameterHeader Header;
132+
// a default scenario is not needed here. Scenarios where ElementText is
133+
// invalid is previously checked and error handled when this method is called.
132134
Header.ParameterType =
133135
StringSwitch<uint32_t>(*ElementText)
134136
.Case("RootCBV", llvm::to_underlying(dxbc::RootParameterType::CBV))

0 commit comments

Comments
 (0)