Skip to content

Commit 0c5abf5

Browse files
Add release notes for pull request #150962,
1 parent 8ea4c38 commit 0c5abf5

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,17 @@ Improvements to Clang's diagnostics
122122
Added a new warning in this group for the case where the attribute is missing/implicit on
123123
an override of a virtual method.
124124

125+
- Fixed an issue where emitted format-signedness diagnostics were not associated with an appropriate
126+
diagnostic id. Besides being incorrect from an API standpoint, this was user visible, e.g.:
127+
"format specifies type 'unsigned int' but the argument has type 'int' [-Wformat]"
128+
"signedness of format specifier 'u' is incompatible with 'c' [-Wformat]"
129+
This was misleading, because even though -Wformat is required in order to emit the diagnostics,
130+
the warning flag the user needs to concerned with here is -Wformat-signedness, which is also
131+
required and is not enabled by default. With the change you'll now see:
132+
"format specifies type 'unsigned int' but the argument has type 'int', which differs in signedness [-Wformat-signedness]"
133+
"signedness of format specifier 'u' is incompatible with 'c' [-Wformat-signedness]"
134+
and the API-visible diagnostic id will be appropriate.
135+
125136
Improvements to Clang's time-trace
126137
----------------------------------
127138

0 commit comments

Comments
 (0)