File tree Expand file tree Collapse file tree 1 file changed +11
-0
lines changed
Expand file tree Collapse file tree 1 file changed +11
-0
lines changed Original file line number Diff line number Diff line change @@ -122,6 +122,17 @@ Improvements to Clang's diagnostics
122122 Added a new warning in this group for the case where the attribute is missing/implicit on
123123 an override of a virtual method.
124124
125+ - Fixed an issue where emitted format-signedness diagnostics were not associated with an appropriate
126+ diagnostic id. Besides being incorrect from an API standpoint, this was user visible, e.g.:
127+ "format specifies type 'unsigned int' but the argument has type 'int' [-Wformat]"
128+ "signedness of format specifier 'u' is incompatible with 'c' [-Wformat]"
129+ This was misleading, because even though -Wformat is required in order to emit the diagnostics,
130+ the warning flag the user needs to concerned with here is -Wformat-signedness, which is also
131+ required and is not enabled by default. With the change you'll now see:
132+ "format specifies type 'unsigned int' but the argument has type 'int', which differs in signedness [-Wformat-signedness]"
133+ "signedness of format specifier 'u' is incompatible with 'c' [-Wformat-signedness]"
134+ and the API-visible diagnostic id will be appropriate.
135+
125136Improvements to Clang's time-trace
126137----------------------------------
127138
You can’t perform that action at this time.
0 commit comments