Skip to content

Commit 0ce25d1

Browse files
authored
Fix clang-tidy flags
1 parent 87fc9c0 commit 0ce25d1

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

clang-tools-extra/clang-tidy/llvm/UseNewMLIROpBuilderCheck.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ EditGenerator rewrite(RangeSelector Call, RangeSelector Builder) {
8888
return llvm::make_error<llvm::StringError>(llvm::errc::invalid_argument,
8989
"unexpected end of file");
9090
}
91-
const bool hasArgs = Arg->getKind() != clang::tok::r_paren;
91+
const bool HasArgs = Arg->getKind() != clang::tok::r_paren;
9292

9393
Expected<CharSourceRange> BuilderRange = Builder(Result);
9494
if (!BuilderRange)
@@ -113,7 +113,7 @@ EditGenerator rewrite(RangeSelector Call, RangeSelector Builder) {
113113
const StringRef OpType = GetText(CharSourceRange::getTokenRange(
114114
LessToken->getEndLoc(), EndToken->getLastLoc()));
115115
Replace.Replacement = llvm::formatv("{}::create({}{}", OpType, BuilderText,
116-
hasArgs ? ", " : "");
116+
HasArgs ? ", " : "");
117117

118118
return SmallVector<Edit, 1>({Replace});
119119
};
@@ -124,17 +124,17 @@ RewriteRuleWith<std::string> useNewMlirOpBuilderCheckRule() {
124124
"'builder.create<OpType>(...)'");
125125
// Match a create call on an OpBuilder.
126126
auto BuilderType = cxxRecordDecl(isSameOrDerivedFrom("::mlir::OpBuilder"));
127-
ast_matchers::internal::Matcher<Stmt> base = cxxMemberCallExpr(
127+
ast_matchers::internal::Matcher<Stmt> Base = cxxMemberCallExpr(
128128
on(expr(anyOf(hasType(BuilderType), hasType(pointsTo(BuilderType))))
129129
.bind("builder")),
130130
callee(expr().bind("call")),
131131
callee(cxxMethodDecl(hasTemplateArgument(0, templateArgument()),
132132
hasName("create"))));
133133
return applyFirst(
134134
// Attempt rewrite given an lvalue builder, else just warn.
135-
{makeRule(cxxMemberCallExpr(unless(on(cxxTemporaryObjectExpr())), base),
135+
{makeRule(cxxMemberCallExpr(unless(on(cxxTemporaryObjectExpr())), Base),
136136
rewrite(node("call"), node("builder")), message),
137-
makeRule(base, noopEdit(node("call")), message)});
137+
makeRule(Base, noopEdit(node("call")), message)});
138138
}
139139
} // namespace
140140

0 commit comments

Comments
 (0)