function name style, TargetVerifier comment, option name generality

Author: jofrn

llvm/include/llvm/Target/TargetVerifier.h

@@ -12,8 +12,8 @@
 // TargetVerifier looks for constructions invalid to a particular target
 // machine.
 //
-// To see what specifically is checked, look at TargetVerifier.cpp or an
-// individual backend's TargetVerifier.
+// To see what specifically is checked, look at an individual backend's
+// TargetVerifier.
 //
 //===----------------------------------------------------------------------===//
 
@@ -35,7 +35,7 @@ class TargetVerifierPass : public PassInfoMixin<TargetVerifierPass> {
 
 class TargetVerify {
 protected:
-  void WriteValues(ArrayRef<const Value *> Vs) {
+  void writeValues(ArrayRef<const Value *> Vs) {
     for (const Value *V : Vs) {
       if (!V)
         continue;
@@ -52,16 +52,16 @@ class TargetVerify {
   ///
   /// This provides a nice place to put a breakpoint if you want to see why
   /// something is not correct.
-  void CheckFailed(const Twine &Message) { MessagesStr << Message << '\n'; }
+  void checkFailed(const Twine &Message) { MessagesStr << Message << '\n'; }
 
   /// A check failed (with values to print).
   ///
   /// This calls the Message-only version so that the above is easier to set
   /// a breakpoint on.
   template <typename T1, typename... Ts>
-  void CheckFailed(const Twine &Message, const T1 &V1, const Ts &...Vs) {
-    CheckFailed(Message);
-    WriteValues({V1, Vs...});
+  void checkFailed(const Twine &Message, const T1 &V1, const Ts &...Vs) {
+    checkFailed(Message);
+    writeValues({V1, Vs...});
   }
 
 public:

llvm/lib/Target/AMDGPU/AMDGPU.h

@@ -552,8 +552,7 @@ extern char &AMDGPUWaitSGPRHazardsLegacyID;
 
 FunctionPass *createAMDGPUTargetVerifierLegacyPass(bool FatalErrors);
 void initializeAMDGPUTargetVerifierLegacyPassPass(PassRegistry &);
-class AMDGPUTargetVerifierPass : public TargetVerifierPass {
-public:
+struct AMDGPUTargetVerifierPass : public TargetVerifierPass {
   PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM) override;
 };
 

llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp

@@ -481,7 +481,7 @@ static cl::opt<bool> HasClosedWorldAssumption(
     cl::desc("Whether has closed-world assumption at link time"),
     cl::init(false), cl::Hidden);
 
-static cl::opt<bool> VerifyTarget("verify-tgt",
+static cl::opt<bool> VerifyTarget("amdgpu-verify-tgt",
                                   cl::desc("Enable the target verifier"));
 
 extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeAMDGPUTarget() {

llvm/lib/Target/AMDGPU/AMDGPUTargetVerifier.cpp

@@ -34,7 +34,7 @@ using namespace llvm;
 #define Check(C, ...)                                                          \
   do {                                                                         \
     if (!(C)) {                                                                \
-      TargetVerify::CheckFailed(__VA_ARGS__);                                  \
+      TargetVerify::checkFailed(__VA_ARGS__);                                  \
     }                                                                          \
   } while (false)
 

llvm/test/CodeGen/AMDGPU/tgt-verify-llc-fail.ll

@@ -1,4 +1,4 @@
-; RUN: llc -mtriple=amdgcn -mcpu=gfx900 -verify-tgt -o - < %s 2>&1 | FileCheck %s
+; RUN: llc -mtriple=amdgcn -mcpu=gfx900 -amdgpu-verify-tgt -o - < %s 2>&1 | FileCheck %s
 
 define amdgpu_cs i32 @nonvoid_shader() {
 ; CHECK: Shaders must return void

llvm/test/CodeGen/AMDGPU/tgt-verify-llc-pass.ll

@@ -1,4 +1,4 @@
-; RUN: llc -mtriple=amdgcn -mcpu=gfx900 -verify-tgt %s -o - 2>&1 | FileCheck %s --allow-empty
+; RUN: llc -mtriple=amdgcn -mcpu=gfx900 -amdgpu-verify-tgt %s -o - 2>&1 | FileCheck %s --allow-empty
 
 define amdgpu_cs void @void_shader() {
 ; CHECK-NOT: Shaders must return void