[ADT] Add const to operator== in ArrayRef.h (#161321)

kazutakahirata · web-flow · commit 0db995e60b6b · 2025-09-30T08:56:27.000-07:00
While I am at it, this patch adds [[nodiscard]].
diff --git a/llvm/include/llvm/ADT/ArrayRef.h b/llvm/include/llvm/ADT/ArrayRef.h
@@ -547,7 +547,8 @@ namespace llvm {
   }
 
   template <typename T>
-  inline bool operator==(SmallVectorImpl<T> &LHS, ArrayRef<T> RHS) {
+  [[nodiscard]] inline bool operator==(const SmallVectorImpl<T> &LHS,
+                                       ArrayRef<T> RHS) {
     return ArrayRef<T>(LHS).equals(RHS);
   }
 
@@ -557,7 +558,8 @@ namespace llvm {
   }
 
   template <typename T>
-  inline bool operator!=(SmallVectorImpl<T> &LHS, ArrayRef<T> RHS) {
+  [[nodiscard]] inline bool operator!=(const SmallVectorImpl<T> &LHS,
+                                       ArrayRef<T> RHS) {
     return !(LHS == RHS);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -547,7 +547,8 @@ namespace llvm {`
`547`	`547`	`}`
`548`	`548`
`549`	`549`	`template <typename T>`
`550`		`- inline bool operator==(SmallVectorImpl<T> &LHS, ArrayRef<T> RHS) {`
	`550`	`+ [[nodiscard]] inline bool operator==(const SmallVectorImpl<T> &LHS,`
	`551`	`+ ArrayRef<T> RHS) {`
`551`	`552`	`return ArrayRef<T>(LHS).equals(RHS);`
`552`	`553`	`}`
`553`	`554`
`@@ -557,7 +558,8 @@ namespace llvm {`
`557`	`558`	`}`
`558`	`559`
`559`	`560`	`template <typename T>`
`560`		`- inline bool operator!=(SmallVectorImpl<T> &LHS, ArrayRef<T> RHS) {`
	`561`	`+ [[nodiscard]] inline bool operator!=(const SmallVectorImpl<T> &LHS,`
	`562`	`+ ArrayRef<T> RHS) {`
`561`	`563`	`return !(LHS == RHS);`
`562`	`564`	`}`
`563`	`565`