Skip to content

Commit 0e3748b

Browse files
committed
Correct the error handling when parseArgs fails in RequestHandler.
1 parent 5c77f71 commit 0e3748b

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

lldb/tools/lldb-dap/Handler/RequestHandler.h

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -132,14 +132,8 @@ class RequestHandler : public BaseRequestHandler {
132132
response.command = request.command;
133133

134134
llvm::Expected<Args> arguments = parseArgs<Args>(request);
135-
if (!arguments) {
136-
HandleErrorResponse(
137-
llvm::make_error<DAPError>(
138-
llvm::formatv("arguments required for command '{0}' "
139-
"but none received",
140-
request.command)
141-
.str()),
142-
response);
135+
if (llvm::Error err = arguments.takeError()) {
136+
HandleErrorResponse(std::move(err), response);
143137
dap.Send(response);
144138
return;
145139
}

0 commit comments

Comments
 (0)