Skip to content

Commit 0e80019

Browse files
committed
Addressing further code review comments
Signed-off-by: Mohammadreza Ameri Mahabadian <[email protected]>
1 parent fd5e115 commit 0e80019

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -767,7 +767,7 @@ void mlir::spirv::AddressOfOp::getAsmResultNames(
767767
// spirv.EXTConstantCompositeReplicate
768768
//===----------------------------------------------------------------------===//
769769

770-
// Returns type of attribute. In case of a TypedAttr this will simply return
770+
// Returns type of attribute. In case of a TypedAttr this will simply return
771771
// the type. But for an ArrayAttr which is untyped and can be multidimensional
772772
// it creates the ArrayType recursively.
773773
static Type getValueType(Attribute attr) {

mlir/lib/Target/SPIRV/Serialization/Serializer.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1187,6 +1187,9 @@ uint32_t Serializer::prepareConstantFp(Location loc, FloatAttr floatAttr,
11871187
return resultID;
11881188
}
11891189

1190+
// Returns type of attribute. In case of a TypedAttr this will simply return
1191+
// the type. But for an ArrayAttr which is untyped and can be multidimensional
1192+
// it creates the ArrayType recursively.
11901193
static Type getValueType(Attribute attr) {
11911194
if (auto typedAttr = dyn_cast<TypedAttr>(attr)) {
11921195
return typedAttr.getType();

0 commit comments

Comments
 (0)