Skip to content

Commit 0f9f681

Browse files
authored
address reviewer comments
1 parent 4d64d0d commit 0f9f681

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

mlir/include/mlir/Dialect/MemRef/IR/MemRefBase.td

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,14 @@ def MemRef_Dialect : Dialect {
1919
manipulation ops, which are not strongly associated with any particular
2020
other dialect or domain abstraction.
2121
}];
22-
let dependentDialects = ["arith::ArithDialect", "ub::UBDialect"];
22+
let dependentDialects = [
23+
// `arith` is a dependency because it is used to materialize constants,
24+
// and in some canonicalization patterns.
25+
"arith::ArithDialect",
26+
// `ub` is a dependency because `AllocaOp::getDefaultValue` can produce a
27+
// `ub.poison` value.
28+
"ub::UBDialect"
29+
];
2330
let hasConstantMaterializer = 1;
2431
}
2532

0 commit comments

Comments
 (0)