[CIR][NFC] Fix warning in MemOrder lowering

andykaylor · andykaylor · commit 104c44d33c82 · 2025-08-20T13:39:39.000-07:00
This fixes a warning about having a default case in a fully covered enum
switch statement.
diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
@@ -1181,9 +1181,8 @@ getLLVMMemOrder(std::optional<cir::MemOrder> memorder) {
     return mlir::LLVM::AtomicOrdering::acq_rel;
   case cir::MemOrder::SequentiallyConsistent:
     return mlir::LLVM::AtomicOrdering::seq_cst;
-  default:
-    llvm_unreachable("unknown memory order");
   }
+  llvm_unreachable("unknown memory order");
 }
 
 mlir::LogicalResult CIRToLLVMLoadOpLowering::matchAndRewrite(

Original file line number	Diff line number	Diff line change
`@@ -1181,9 +1181,8 @@ getLLVMMemOrder(std::optional<cir::MemOrder> memorder) {`
`1181`	`1181`	`return mlir::LLVM::AtomicOrdering::acq_rel;`
`1182`	`1182`	`case cir::MemOrder::SequentiallyConsistent:`
`1183`	`1183`	`return mlir::LLVM::AtomicOrdering::seq_cst;`
`1184`		`- default:`
`1185`		`- llvm_unreachable("unknown memory order");`
`1186`	`1184`	`}`
	`1185`	`+ llvm_unreachable("unknown memory order");`
`1187`	`1186`	`}`
`1188`	`1187`
`1189`	`1188`	`mlir::LogicalResult CIRToLLVMLoadOpLowering::matchAndRewrite(`