self-review: missed clean-up

Author: inbelic

llvm/docs/DirectX/DXILArchitecture.rst

@@ -113,7 +113,7 @@ are grouped into two flows:
 
 The passes to generate DXIL IR follow the flow:
 
-  DXILOpLowering -> DXILPrepare -> DXILTranslateMetadata -> DXILValidateMetadata
+  DXILOpLowering -> DXILPrepare -> DXILTranslateMetadata
 
 Each of these passes has a defined responsibility:
 
@@ -122,8 +122,6 @@ Each of these passes has a defined responsibility:
    namely removing attributes, and inserting bitcasts to allow typed pointers
    to be inserted.
 #. DXILTranslateMetadata transforms and emits all recognized DXIL Metadata.
-#. DXILValidateMetadata validates that all emitted DXIL metadata structures
-   conform to DXIL validation.
 
 The passes to encode DXIL to binary in the DX Container follow the flow:
 

llvm/lib/Target/DirectX/DXILTranslateMetadata.cpp

@@ -504,13 +504,12 @@ static void translateGlobalMetadata(Module &M, DXILResourceMap &DRM,
       EntryShaderFlags = ShaderFlags.getFunctionFlags(EntryProp.Entry);
       if (EntryProp.ShaderStage != MMDI.ShaderProfile)
         reportError(
-            M,
-            "Shader stage '" +
-                Twine(Twine(getShortShaderStage(EntryProp.ShaderStage)) +
-                      "' for entry '" + Twine(EntryProp.Entry->getName()) +
-                      "' different from specified target profile '" +
-                      Twine(Triple::getEnvironmentTypeName(MMDI.ShaderProfile) +
-                            "'")));
+            M, "Shader stage '" +
+                   Twine(getShortShaderStage(EntryProp.ShaderStage)) +
+                   "' for entry '" + Twine(EntryProp.Entry->getName()) +
+                   "' different from specified target profile '" +
+                   Twine(Triple::getEnvironmentTypeName(MMDI.ShaderProfile) +
+                         "'"));
     }
 
     EntryFnMDNodes.emplace_back(emitEntryMD(EntryProp, Signatures, ResourceMD,

llvm/lib/Target/DirectX/DirectX.h

@@ -90,12 +90,6 @@ void initializeDXILTranslateMetadataLegacyPass(PassRegistry &);
 /// Pass to emit metadata for DXIL.
 ModulePass *createDXILTranslateMetadataLegacyPass();
 
-/// Initializer for DXILValidateMetadata.
-void initializeDXILValidateMetadataLegacyPass(PassRegistry &);
-
-/// Pass to validate metadata for DXIL.
-ModulePass *createDXILValidateMetadataLegacyPass();
-
 /// Pass to pretty print DXIL metadata.
 ModulePass *createDXILPrettyPrinterLegacyPass(raw_ostream &OS);