[Summary] move the ast matcher callback out of the attribute declaration

Author: isuckatcs

clang/include/clang/Sema/SummaryAttribute.h

@@ -37,14 +37,6 @@ class SummaryAttr {
 };
 
 class NoWriteGlobalAttr : public SummaryAttr {
-  class Callback : public ast_matchers::MatchFinder::MatchCallback {
-  public:
-    bool WriteGlobal = false;
-
-    void
-    run(const ast_matchers::MatchFinder::MatchResult &Result) override final;
-  };
-
   NoWriteGlobalAttr() : SummaryAttr(NO_WRITE_GLOBAL, "no_write_global") {}
 
 public:

clang/lib/Sema/SummaryAttribute.cpp

@@ -2,19 +2,24 @@
 #include "clang/Sema/SummaryContext.h"
 
 namespace clang {
-void NoWriteGlobalAttr::Callback::run(
-    const ast_matchers::MatchFinder::MatchResult &Result) {
-  const auto *Assignment = Result.Nodes.getNodeAs<BinaryOperator>("assignment");
-  if (!Assignment)
-    return;
-
-  WriteGlobal = true;
-}
-
 bool NoWriteGlobalAttr::infer(const FunctionDecl *FD) const {
   using namespace ast_matchers;
   MatchFinder Finder;
-  Callback CB;
+
+  class Callback : public ast_matchers::MatchFinder::MatchCallback {
+  public:
+    bool WriteGlobal = false;
+
+    void
+    run(const ast_matchers::MatchFinder::MatchResult &Result) override final {
+      const auto *Assignment =
+          Result.Nodes.getNodeAs<BinaryOperator>("assignment");
+      if (!Assignment)
+        return;
+
+      WriteGlobal = true;
+    }
+  } CB;
 
   Finder.addMatcher(
       functionDecl(forEachDescendant(