Address code review feedback.

Author: maksimsab

llvm/lib/Transforms/Utils/SYCLModuleSplit.cpp

@@ -21,6 +21,7 @@
 #include "llvm/IR/PassManager.h"
 #include "llvm/IR/PassManagerImpl.h"
 #include "llvm/IRPrinter/IRPrintingPasses.h"
+#include "llvm/Support/Compiler.h"
 #include "llvm/Support/Debug.h"
 #include "llvm/Support/Error.h"
 #include "llvm/Support/FileSystem.h"
@@ -37,7 +38,7 @@
 
 using namespace llvm;
 
-#define DEBUG_TYPE "sycl_module_split"
+#define DEBUG_TYPE "sycl-module-split"
 
 static bool isKernel(const Function &F) {
   return F.getCallingConv() == CallingConv::SPIR_KERNEL ||
@@ -75,7 +76,8 @@ struct EntryPointGroup {
                   EntryPointSet Functions = EntryPointSet())
       : GroupName(GroupName), Functions(std::move(Functions)) {}
 
-  void dump() const {
+#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
+  LLVM_DUMP_METHOD void dump() const {
     constexpr size_t INDENT = 4;
     dbgs().indent(INDENT) << "ENTRY POINTS"
                           << " " << GroupName << " {\n";
@@ -84,6 +86,7 @@ struct EntryPointGroup {
 
     dbgs().indent(INDENT) << "}\n";
   }
+#endif
 };
 
 /// Annotates an llvm::Module with information necessary to perform and track
@@ -133,11 +136,13 @@ class ModuleDesc {
     return std::string(ST);
   }
 
-  void dump() const {
+#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
+  LLVM_DUMP_METHOD void dump() const {
     dbgs() << "ModuleDesc[" << M->getName() << "] {\n";
     EntryPoints.dump();
     dbgs() << "}\n";
   }
+#endif
 };
 
 // Represents "dependency" or "use" graph of global objects (functions and

llvm/tools/llvm-split/llvm-split.cpp

@@ -32,8 +32,8 @@
 #include "llvm/Transforms/Utils/SYCLUtils.h"
 #include "llvm/Transforms/Utils/SplitModule.h"
 
-#include <vector>
 #include <string>
+#include <vector>
 
 using namespace llvm;
 
@@ -100,7 +100,7 @@ void writeStringToFile(std::string_view Content, StringRef Path) {
 }
 
 void writeSplitModulesAsTable(ArrayRef<SYCLSplitModule> SplitModules,
-                             StringRef Path) {
+                              StringRef Path) {
   std::vector<std::string> Columns = {"Code", "Symbols"};
   SYCLStringTable Table;
   Table.emplace_back(std::move(Columns));