changes from review

Author: devnexen

compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp

@@ -813,6 +813,11 @@ INTERCEPTOR(int, madvise, void *addr, size_t length, int flag) {
   return REAL(madvise)(addr, length, flag);
 }
 
+INTERCEPTOR(int, posix_madvise, void *addr, size_t length, int flag) {
+  __rtsan_notify_intercepted_call("posix_madvise");
+  return REAL(posix_madvise)(addr, length, flag);
+}
+
 INTERCEPTOR(int, mprotect, void *addr, size_t length, int prot) {
   __rtsan_notify_intercepted_call("mprotect");
   return REAL(mprotect)(addr, length, prot);
@@ -1173,6 +1178,7 @@ void __rtsan::InitializeInterceptors() {
   RTSAN_MAYBE_INTERCEPT_MMAP64;
   INTERCEPT_FUNCTION(munmap);
   INTERCEPT_FUNCTION(madvise);
+  INTERCEPT_FUNCTION(posix_madvise);
   INTERCEPT_FUNCTION(mprotect);
   INTERCEPT_FUNCTION(msync);
   INTERCEPT_FUNCTION(mincore);

compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp

@@ -244,6 +244,12 @@ TEST_F(RtsanOpenedMmapTest, MadviseDiesWhenRealtime) {
   ExpectNonRealtimeSurvival(Func);
 }
 
+TEST_F(RtsanOpenedMmapTest, PosixMadviseDiesWhenRealtime) {
+  auto Func = [this]() { posix_madvise(GetAddr(), GetSize(), MADV_NORMAL); };
+  ExpectRealtimeDeath(Func, "posix_madvise");
+  ExpectNonRealtimeSurvival(Func);
+}
+
 TEST_F(RtsanOpenedMmapTest, MprotectDiesWhenRealtime) {
   auto Func = [this]() { mprotect(GetAddr(), GetSize(), PROT_READ); };
   ExpectRealtimeDeath(Func, "mprotect");
@@ -258,11 +264,11 @@ TEST_F(RtsanOpenedMmapTest, MsyncDiesWhenRealtime) {
 
 TEST_F(RtsanOpenedMmapTest, MincoreDiesWhenRealtime) {
 #if SANITIZER_APPLE
-  char vec[GetSize() / 1024];
+  std::vector<char>(GetSize() / 1024);
 #else
-  unsigned char vec[GetSize() / 1024];
+  std::vector<unsigned char>(GetSize() / 1024);
 #endif
-  auto Func = [this, &vec]() { mincore(GetAddr(), GetSize(), vec); };
+  auto Func = [this, &vec]() { mincore(GetAddr(), GetSize(), vec.data()); };
   ExpectRealtimeDeath(Func, "mincore");
   ExpectNonRealtimeSurvival(Func);
 }