Skip to content

Commit 11c3a21

Browse files
steakhaltstellar
authored andcommitted
[analyzer] Workaround crash on encountering Class non-type template parameters
The Clang Static Analyzer will crash on this code: ```lang=C++ struct Box { int value; }; template <Box V> int get() { return V.value; } template int get<Box{-1}>(); ``` https://godbolt.org/z/5Yb1sMMMb The problem is that we don't account for encountering `TemplateParamObjectDecl`s within the `DeclRefExpr` handler in the `ExprEngine`. IMO we should create a new memregion for representing such template param objects, to model their language semantics. Such as: - it should have global static storage - for two identical values, their addresses should be identical as well http://eel.is/c%2B%2Bdraft/temp.param#8 I was thinking of introducing a `TemplateParamObjectRegion` under `DeclRegion` for this purpose. It could have `TemplateParamObjectDecl` as a field. The `TemplateParamObjectDecl::getValue()` returns `APValue`, which might represent multiple levels of structures, unions and other goodies - making the transformation from `APValue` to `SVal` a bit complicated. That being said, for now, I think having `Unknowns` for such cases is definitely an improvement to crashing, hence I'm proposing this patch. Reviewed By: xazax.hun Differential Revision: https://reviews.llvm.org/D135763 (cherry picked from commit b062ee7)
1 parent 0988add commit 11c3a21

File tree

2 files changed

+39
-0
lines changed

2 files changed

+39
-0
lines changed

clang/lib/StaticAnalyzer/Core/ExprEngine.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2839,6 +2839,12 @@ void ExprEngine::VisitCommonDeclRefExpr(const Expr *Ex, const NamedDecl *D,
28392839
return;
28402840
}
28412841

2842+
if (const auto *TPO = dyn_cast<TemplateParamObjectDecl>(D)) {
2843+
// FIXME: We should meaningfully implement this.
2844+
(void)TPO;
2845+
return;
2846+
}
2847+
28422848
llvm_unreachable("Support for this Decl not implemented.");
28432849
}
28442850

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection \
2+
// RUN: -analyzer-config eagerly-assume=false -std=c++20 -verify %s
3+
4+
template <class T> void clang_analyzer_dump(T);
5+
void clang_analyzer_eval(bool);
6+
7+
struct Box {
8+
int value;
9+
};
10+
bool operator ==(Box lhs, Box rhs) {
11+
return lhs.value == rhs.value;
12+
}
13+
template <Box V> void dumps() {
14+
clang_analyzer_dump(V); // expected-warning {{lazyCompoundVal}}
15+
clang_analyzer_dump(&V); // expected-warning {{Unknown}}
16+
clang_analyzer_dump(V.value); // expected-warning {{Unknown}} FIXME: It should be '6 S32b'.
17+
clang_analyzer_dump(&V.value); // expected-warning {{Unknown}}
18+
}
19+
template void dumps<Box{6}>();
20+
21+
// [temp.param].7.3.2:
22+
// "All such template parameters in the program of the same type with the
23+
// same value denote the same template parameter object."
24+
template <Box A1, Box A2, Box B1, Box B2> void stable_addresses() {
25+
clang_analyzer_eval(&A1 == &A2); // expected-warning {{UNKNOWN}} FIXME: It should be TRUE.
26+
clang_analyzer_eval(&B1 == &B2); // expected-warning {{UNKNOWN}} FIXME: It should be TRUE.
27+
clang_analyzer_eval(&A1 == &B2); // expected-warning {{UNKNOWN}} FIXME: It should be FALSE.
28+
29+
clang_analyzer_eval(A1 == A2); // expected-warning {{UNKNOWN}} FIXME: It should be TRUE.
30+
clang_analyzer_eval(B1 == B2); // expected-warning {{UNKNOWN}} FIXME: It should be TRUE.
31+
clang_analyzer_eval(A1 == B2); // expected-warning {{UNKNOWN}} FIXME: It should be FALSE.
32+
}
33+
template void stable_addresses<Box{1}, Box{1}, Box{2}, Box{2}>();

0 commit comments

Comments
 (0)