Address PR feedback

Author: bharadwajy

llvm/lib/Target/DirectX/DXILShaderFlags.cpp

@@ -153,11 +153,11 @@ void ModuleShaderFlags::initialize(Module &M, DXILResourceTypeMap &DRTM,
         MMDI.EntryPropertyVec[0].Entry->hasFnAttribute(
             llvm::Attribute::OptimizeNone);
     // Ensure all entry functions have the same optimization attribute
-    for (auto EF : MMDI.EntryPropertyVec)
+    for (const auto &EntryFunProps : MMDI.EntryPropertyVec)
       if (CombinedSFMask.DisableOptimizations !=
-          EF.Entry->hasFnAttribute(llvm::Attribute::OptimizeNone))
-        EF.Entry->getContext().diagnose(DiagnosticInfoUnsupported(
-            *(EF.Entry), "Inconsistent optnone attribute "));
+          EntryFunProps.Entry->hasFnAttribute(llvm::Attribute::OptimizeNone))
+        EntryFunProps.Entry->getContext().diagnose(DiagnosticInfoUnsupported(
+            *(EntryFunProps.Entry), "Inconsistent optnone attribute "));
   }
 }
 

llvm/test/CodeGen/DirectX/ShaderFlags/disable-opt-cs.ll

@@ -16,9 +16,6 @@
 ; void main() {}
 ; EOF
 
-; ModuleID = '-'
-source_filename = "-"
-target datalayout = "e-m:e-p:32:32-i1:32-i8:8-i16:16-i32:32-i64:64-f16:16-f32:32-f64:64-n8:16:32:64"
 target triple = "dxilv1.0-pc-shadermodel6.0-compute"
 
 ; Function Attrs: convergent noinline norecurse optnone
@@ -35,9 +32,3 @@ entry:
 
 attributes #0 = { convergent noinline norecurse optnone "approx-func-fp-math"="true" "hlsl.numthreads"="1,1,1" "hlsl.shader"="compute" "no-infs-fp-math"="true" "no-nans-fp-math"="true" "no-signed-zeros-fp-math"="true" "no-trapping-math"="true" "stack-protector-buffer-size"="8" }
 attributes #1 = { alwaysinline convergent mustprogress norecurse nounwind "approx-func-fp-math"="true" "no-infs-fp-math"="true" "no-nans-fp-math"="true" "no-signed-zeros-fp-math"="true" "no-trapping-math"="true" "stack-protector-buffer-size"="8" }
-
-!llvm.module.flags = !{!0}
-!dx.valver = !{!1}
-
-!0 = !{i32 1, !"wchar_size", i32 4}
-!1 = !{i32 1, i32 8}

llvm/test/CodeGen/DirectX/ShaderFlags/disable-opt-lib.ll

@@ -19,9 +19,6 @@
 ; int foo() {return 0;}
 ; EOF
 
-; ModuleID = '-'
-source_filename = "-"
-target datalayout = "e-m:e-p:32:32-i1:32-i8:8-i16:16-i32:32-i64:64-f16:16-f32:32-f64:64-n8:16:32:64"
 target triple = "dxilv1.3-pc-shadermodel6.3-library"
 
 ; Function Attrs: convergent mustprogress noinline norecurse nounwind optnone
@@ -45,9 +42,3 @@ entry:
 
 attributes #0 = { convergent mustprogress noinline norecurse nounwind optnone "approx-func-fp-math"="true" "no-infs-fp-math"="true" "no-nans-fp-math"="true" "no-signed-zeros-fp-math"="true" "no-trapping-math"="true" "stack-protector-buffer-size"="8" }
 attributes #1 = { convergent noinline norecurse optnone "approx-func-fp-math"="true" "hlsl.numthreads"="1,1,1" "hlsl.shader"="compute" "no-infs-fp-math"="true" "no-nans-fp-math"="true" "no-signed-zeros-fp-math"="true" "no-trapping-math"="true" "stack-protector-buffer-size"="8" }
-
-!llvm.module.flags = !{!0}
-!dx.valver = !{!1}
-
-!0 = !{i32 1, !"wchar_size", i32 4}
-!1 = !{i32 1, i32 8}