~

zeyi2 · zeyi2 · commit 11e86d64146e · 2025-12-04T00:30:08.000+08:00
diff --git a/clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp
@@ -1175,6 +1175,8 @@ class UserDefinedConversionSelector {
     }
 
     if (HowManyGoodConversions == 1) {
+      assert(BestConversion &&
+             "BestConversion must be set if HowManyGoodConversions is 1");
       LLVM_DEBUG(llvm::dbgs()
                  << "--- selectUserDefinedConv. Unique result. Flags: "
                  << formatMixFlags(BestConversion->Flags) << '\n');

Original file line number	Diff line number	Diff line change
`@@ -1175,6 +1175,8 @@ class UserDefinedConversionSelector {`
`1175`	`1175`	`}`
`1176`	`1176`
`1177`	`1177`	`if (HowManyGoodConversions == 1) {`
	`1178`	`+ assert(BestConversion &&`
	`1179`	`+ "BestConversion must be set if HowManyGoodConversions is 1");`
`1178`	`1180`	`LLVM_DEBUG(llvm::dbgs()`
`1179`	`1181`	`<< "--- selectUserDefinedConv. Unique result. Flags: "`
`1180`	`1182`	`<< formatMixFlags(BestConversion->Flags) << '\n');`