Skip to content

Commit 1234571

Browse files
committed
Address more feedback
1 parent 6081efa commit 1234571

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

clang/include/clang/Sema/Sema.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3669,7 +3669,7 @@ class Sema final : public SemaBase {
36693669
/// cause problems if the variable is mutable, its initialization is
36703670
/// effectful, or its address is taken.
36713671
bool GloballyUniqueObjectMightBeAccidentallyDuplicated(const VarDecl *Dcl);
3672-
void DiagnoseDangerousUniqueObjectDuplication(const VarDecl *Dcl);
3672+
void DiagnoseUniqueObjectDuplication(const VarDecl *Dcl);
36733673

36743674
/// AddInitializerToDecl - Adds the initializer Init to the
36753675
/// declaration dcl. If DirectInit is true, this is C++ direct

clang/lib/Sema/SemaDecl.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13440,7 +13440,7 @@ bool Sema::GloballyUniqueObjectMightBeAccidentallyDuplicated(
1344013440
return true;
1344113441
}
1344213442

13443-
void Sema::DiagnoseDangerousUniqueObjectDuplication(const VarDecl *VD) {
13443+
void Sema::DiagnoseUniqueObjectDuplication(const VarDecl *VD) {
1344413444
// If this object has external linkage and hidden visibility, it might be
1344513445
// duplicated when built into a shared library, which causes problems if it's
1344613446
// mutable (since the copies won't be in sync) or its initialization has side
@@ -14708,7 +14708,7 @@ void Sema::CheckCompleteVariableDeclaration(VarDecl *var) {
1470814708
return;
1470914709
}
1471014710

14711-
DiagnoseDangerousUniqueObjectDuplication(var);
14711+
DiagnoseUniqueObjectDuplication(var);
1471214712

1471314713
// Require the destructor.
1471414714
if (!type->isDependentType())

0 commit comments

Comments
 (0)