Skip to content

Commit 1249794

Browse files
committed
small fixes
1 parent e6c4db3 commit 1249794

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

mlir/include/mlir/Dialect/XeGPU/IR/XeGPUOps.td

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,6 @@ def XeGPU_PrefetchOp : XeGPU_Op<"prefetch", []> {
665665
prop-dict
666666
attr-dict `:` type(operands)
667667
}];
668-
// type($source) (type($offsets)^)?
669668

670669
let builders = [
671670
OpBuilder<(ins "Value": $source,
@@ -763,10 +762,6 @@ def XeGPU_LoadGatherOp : XeGPU_Op<"load", [MemoryEffects<[MemRead]>]> {
763762
$mask prop-dict
764763
attr-dict `:` type(operands) `->` type($value)
765764
}];
766-
767-
// functional-type(operands, results)
768-
// type($source) (type($offsets)^ )? `,` type($mask) `->` type($value)
769-
770765

771766
let builders = [
772767
OpBuilder<(ins "Type": $value, "Value": $source, "Value": $mask,
@@ -855,7 +850,6 @@ def XeGPU_StoreScatterOp : XeGPU_Op<"store", [MemoryEffects<[MemWrite]>]> {
855850
prop-dict
856851
attr-dict `:` type(operands)
857852
}];
858-
// type($value) `,` qualified(type($dest)) (type($offsets)^)? `,` type($mask)
859853

860854
let builders = [
861855
OpBuilder<(ins "Value": $value, "Value": $dest, "Value": $mask,

mlir/lib/Dialect/XeGPU/Transforms/XeGPUUnroll.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,7 @@ struct UnrollLoadGatherOp : public UnrollPattern<xegpu::LoadGatherOp> {
502502
SmallVector<Type> convertedTdescTypes =
503503
getUnrolledTypes(tdescTy, *targetShape);
504504
SmallVector<Value> convertedTdescs = pack(
505-
op.getSource(), convertedTdescTypes, *targetShape, loc, rewriter);
505+
op.getTensorDesc(), convertedTdescTypes, *targetShape, loc, rewriter);
506506

507507
SmallVector<Type> convertedMaskTypes;
508508
SmallVector<Value> convertedMasks;

mlir/test/Dialect/XeGPU/invalid.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ func.func @load_gather_offset_wi(%src: ui64) {
405405
}
406406

407407
// -----
408-
func.func @store_scatter_offset(%src: memref<?xf16>) {
408+
func.func @store_scatter_offset_sg(%src: memref<?xf16>) {
409409
%val = arith.constant dense<2.9>: vector<4xf16>
410410
%offsets = arith.constant dense<[0]> : vector<1xindex>
411411
%mask = arith.constant dense<1>: vector<1xi1>

0 commit comments

Comments
 (0)