Skip to content

Commit 1253ae1

Browse files
committed
[PR] dtraev - FAIL, remove unneeded return statements
1 parent 5565fe2 commit 1253ae1

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,7 @@ TEST(TestRtsanInterceptors, SchedYieldDiesWhenRealtime) {
248248
/*
249249
Filesystem
250250
*/
251+
251252
TEST_F(RtsanFileTest, OpenDiesWhenRealtime) {
252253
auto Func = [this]() { open(GetTemporaryFilePath(), O_RDONLY); };
253254
ExpectRealtimeDeath(Func, MAYBE_APPEND_64("open"));
@@ -396,15 +397,13 @@ TEST(TestRtsanInterceptors, IoctlBehavesWithOutputPointer) {
396397
if (sock == -1) {
397398
perror("socket");
398399
GTEST_SKIP();
399-
return;
400400
}
401401

402402
struct ifaddrs *ifaddr = nullptr;
403403
if (getifaddrs(&ifaddr) == -1 || ifaddr == nullptr) {
404404
perror("getifaddrs");
405405
close(sock);
406406
GTEST_SKIP();
407-
return;
408407
}
409408

410409
struct ifreq ifr {};
@@ -415,8 +414,7 @@ TEST(TestRtsanInterceptors, IoctlBehavesWithOutputPointer) {
415414
perror("ioctl");
416415
close(sock);
417416
freeifaddrs(ifaddr);
418-
ASSERT_TRUE(false) << "ioctl failed";
419-
return;
417+
FAIL();
420418
}
421419

422420
freeifaddrs(ifaddr);

0 commit comments

Comments
 (0)