review comments

ergawy · ergawy · commit 12fe4d2b932e · 2025-09-21T01:35:18.000-05:00
diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
@@ -3508,7 +3508,7 @@ Expected<Function *> OpenMPIRBuilder::createReductionFunction(
       if (!Builder.GetInsertBlock())
         return ReductionFunc;
 
-      Builder.SetInsertPoint(AfterIP->getBlock(), AfterIP->getPoint());
+      Builder.restoreIP(*AfterIP);
       Builder.CreateStore(Reduced, LHSPtr);
     }
   }
@@ -3753,7 +3753,7 @@ OpenMPIRBuilder::InsertPointOrErrorTy OpenMPIRBuilder::createReductionsGPU(
           RI.ReductionGen(Builder.saveIP(), RHSValue, LHSValue, Reduced);
       if (!AfterIP)
         return AfterIP.takeError();
-      Builder.SetInsertPoint(AfterIP->getBlock(), AfterIP->getPoint());
+      Builder.restoreIP(*AfterIP);
       Builder.CreateStore(Reduced, LHS, false);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -3508,7 +3508,7 @@ Expected<Function *> OpenMPIRBuilder::createReductionFunction(`
`3508`	`3508`	`if (!Builder.GetInsertBlock())`
`3509`	`3509`	`return ReductionFunc;`
`3510`	`3510`
`3511`		`- Builder.SetInsertPoint(AfterIP->getBlock(), AfterIP->getPoint());`
	`3511`	`+ Builder.restoreIP(*AfterIP);`
`3512`	`3512`	`Builder.CreateStore(Reduced, LHSPtr);`
`3513`	`3513`	`}`
`3514`	`3514`	`}`
`@@ -3753,7 +3753,7 @@ OpenMPIRBuilder::InsertPointOrErrorTy OpenMPIRBuilder::createReductionsGPU(`
`3753`	`3753`	`RI.ReductionGen(Builder.saveIP(), RHSValue, LHSValue, Reduced);`
`3754`	`3754`	`if (!AfterIP)`
`3755`	`3755`	`return AfterIP.takeError();`
`3756`		`- Builder.SetInsertPoint(AfterIP->getBlock(), AfterIP->getPoint());`
	`3756`	`+ Builder.restoreIP(*AfterIP);`
`3757`	`3757`	`Builder.CreateStore(Reduced, LHS, false);`
`3758`	`3758`	`}`
`3759`	`3759`	`}`