Skip to content

Commit 133e848

Browse files
committed
improve test comments
1 parent 525a961 commit 133e848

File tree

1 file changed

+5
-6
lines changed
  • clang/test/DebugInfo/KeyInstructions

1 file changed

+5
-6
lines changed

clang/test/DebugInfo/KeyInstructions/for.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
// RUN: %clang_cc1 -triple x86_64-linux-gnu -gkey-instructions -x c %s -debug-info-kind=line-tables-only -emit-llvm -o - \
55
// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank
66

7-
// Perennial quesiton: should the inc be its own source atom or not
7+
// Perennial question: should the inc be its own source atom or not
88
// (currently it is).
99

10-
// FIXME: See do.c and while.c regarding cmp and cond br groups.
10+
// TODO: See do.c and while.c regarding cmp and cond br groups.
1111

1212
void a(int A) {
1313
// CHECK: entry:
@@ -16,10 +16,9 @@ void a(int A) {
1616
// CHECK: %cmp = icmp slt i32 %0, %1, !dbg [[G2R1:!.*]]
1717
// CHECK: br i1 %cmp, label %for.body, label %for.end, !dbg [[G3R1:!.*]]
1818

19-
// FIXME: Added uncond br group here which is useful for O0, which we're
20-
// no longer targeting. With optimisations loop rotate puts the condition
21-
// into for.inc and simplifycfg smooshes that and for.body together, so
22-
// it's not clear whether it adds any value.
19+
// TODO: The unconditional br is given an atom group here which is useful for
20+
// O0. Since we're no longer targeting O0 we should reevaluate whether this
21+
// adds any value.
2322
// CHECK: for.body:
2423
// CHECK: br label %for.inc, !dbg [[G5R1:!.*]]
2524

0 commit comments

Comments
 (0)