File tree Expand file tree Collapse file tree 1 file changed +5
-6
lines changed
clang/test/DebugInfo/KeyInstructions Expand file tree Collapse file tree 1 file changed +5
-6
lines changed Original file line number Diff line number Diff line change 4
4
// RUN: %clang_cc1 -triple x86_64-linux-gnu -gkey-instructions -x c %s -debug-info-kind=line-tables-only -emit-llvm -o - \
5
5
// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank
6
6
7
- // Perennial quesiton : should the inc be its own source atom or not
7
+ // Perennial question : should the inc be its own source atom or not
8
8
// (currently it is).
9
9
10
- // FIXME : See do.c and while.c regarding cmp and cond br groups.
10
+ // TODO : See do.c and while.c regarding cmp and cond br groups.
11
11
12
12
void a (int A ) {
13
13
// CHECK: entry:
@@ -16,10 +16,9 @@ void a(int A) {
16
16
// CHECK: %cmp = icmp slt i32 %0, %1, !dbg [[G2R1:!.*]]
17
17
// CHECK: br i1 %cmp, label %for.body, label %for.end, !dbg [[G3R1:!.*]]
18
18
19
- // FIXME: Added uncond br group here which is useful for O0, which we're
20
- // no longer targeting. With optimisations loop rotate puts the condition
21
- // into for.inc and simplifycfg smooshes that and for.body together, so
22
- // it's not clear whether it adds any value.
19
+ // TODO: The unconditional br is given an atom group here which is useful for
20
+ // O0. Since we're no longer targeting O0 we should reevaluate whether this
21
+ // adds any value.
23
22
// CHECK: for.body:
24
23
// CHECK: br label %for.inc, !dbg [[G5R1:!.*]]
25
24
You can’t perform that action at this time.
0 commit comments