Skip to content

Commit 13ef7db

Browse files
committed
replace cmake rule with macro
1 parent 3eb3a5d commit 13ef7db

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

libc/src/__support/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ add_subdirectory(time)
393393

394394
# Requires access to uchar header which is not on macos
395395
# Therefore, cannot currently build this on macos in overlay mode
396-
if(NOT (LIBC_TARGET_OS_IS_DARWIN OR LIBC_TARGET_OS_IS_WINDOWS))
396+
if(NOT (LIBC_TARGET_OS_IS_DARWIN))
397397
add_subdirectory(wchar)
398398
endif()
399399

libc/test/src/__support/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,6 @@ add_subdirectory(time)
277277
add_subdirectory(threads)
278278
# Requires access to uchar header which is not on MacOS
279279
# Cannot currently build this on MacOS in overlay mode
280-
if(NOT (LIBC_TARGET_OS_IS_DARWIN OR LIBC_TARGET_OS_IS_WINDOWS))
280+
if(NOT (LIBC_TARGET_OS_IS_DARWIN))
281281
add_subdirectory(wchar)
282282
endif()

libc/test/src/__support/wchar/string_converter_test.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9+
// TODO: add support for 16-bit widechars to StringConverter to remove this
10+
// macro
11+
#ifndef LIBC_TARGET_OS_IS_WINDOWS
12+
913
#include "hdr/errno_macros.h"
1014
#include "hdr/types/char32_t.h"
1115
#include "hdr/types/char8_t.h"
@@ -352,3 +356,5 @@ TEST(LlvmLibcStringConverterTest, DestLimitUTF32To8) {
352356
ASSERT_FALSE(res.has_value());
353357
ASSERT_EQ(static_cast<int>(sc.getSourceIndex()), 1);
354358
}
359+
360+
#endif

0 commit comments

Comments
 (0)