Apply suggestions from code review

Wolfram70 · grypp · Wolfram70 · commit 140c37d8c7b8 · 2025-05-19T15:55:12.000+05:30
Co-authored-by: Guray Ozen &lt;guray.ozen@gmail.com&gt;
diff --git a/mlir/include/mlir/Dialect/LLVMIR/NVVMRequiresSMTraits.td b/mlir/include/mlir/Dialect/LLVMIR/NVVMRequiresSMTraits.td
@@ -27,6 +27,8 @@ def RequiresSMInterface: OpInterface<"RequiresSMInterface"> {
   ];
 }
 
+// OP requires a specified minimum SM value or higher; 
+// it is not architecture-specific.
 class NVVMRequiresSM<int minVersion> :
   ParamNativeOpTrait<"NVVMRequiresSM", !cast<string>(minVersion)>;
 
@@ -35,6 +37,8 @@ class StrJoin<string sep, list<string> str_list> {
                !if(!eq(a, ""), b, !if(!eq(b, ""), a, !strconcat(a, sep, b))));
 }
 
+// OP requires an exact SM match along with 
+// architecture acceleration.
 class NVVMRequiresSMa<list<int> smVersions> :
   ParamNativeOpTrait<"NVVMRequiresSMa",
                       StrJoin<",", !foreach(vers, smVersions,

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,8 @@ def RequiresSMInterface: OpInterface<"RequiresSMInterface"> {`
`27`	`27`	`];`
`28`	`28`	`}`
`29`	`29`
	`30`	`+// OP requires a specified minimum SM value or higher;`
	`31`	`+// it is not architecture-specific.`
`30`	`32`	`class NVVMRequiresSM<int minVersion> :`
`31`	`33`	`ParamNativeOpTrait<"NVVMRequiresSM", !cast<string>(minVersion)>;`
`32`	`34`
`@@ -35,6 +37,8 @@ class StrJoin<string sep, list<string> str_list> {`
`35`	`37`	`!if(!eq(a, ""), b, !if(!eq(b, ""), a, !strconcat(a, sep, b))));`
`36`	`38`	`}`
`37`	`39`
	`40`	`+// OP requires an exact SM match along with`
	`41`	`+// architecture acceleration.`
`38`	`42`	`class NVVMRequiresSMa<list<int> smVersions> :`
`39`	`43`	`ParamNativeOpTrait<"NVVMRequiresSMa",`
`40`	`44`	`StrJoin<",", !foreach(vers, smVersions,`